[PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Geert Uytterhoeven]

"make dt_binding_check":

    Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)

The first line of the description ends with a colon, hence the block
needs to be marked with a "|".

Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml
index 77750df0c2c45e19..88611720545df2ce 100644
--- a/Documentation/devicetree/bindings/net/adi,adin.yaml
+++ b/Documentation/devicetree/bindings/net/adi,adin.yaml
@@ -37,7 +37,8 @@ properties:
     default: 8
 
   adi,phy-output-clock:
-    description: Select clock output on GP_CLK pin. Two clocks are available:
+    description: |
+      Select clock output on GP_CLK pin. Two clocks are available:
       A 25MHz reference and a free-running 125MHz.
       The phy can alternatively automatically switch between the reference and
       the 125MHz clocks based on its internal state.
-- 
2.25.1

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Geert Uytterhoeven]

On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> "make dt_binding_check":
>
>     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
>
> The first line of the description ends with a colon, hence the block
> needs to be marked with a "|".
>
> Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-

Alexandru Ardelean's email address bounces, while he is listed as
a maintainer in several DT bindings files.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Jakub Kicinski]

On Tue, 24 May 2022 16:30:18 +0200 Geert Uytterhoeven wrote:
> On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > "make dt_binding_check":
> >
> >     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> >
> > The first line of the description ends with a colon, hence the block
> > needs to be marked with a "|".
> >
> > Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-  
> 
> Alexandru Ardelean's email address bounces, while he is listed as
> a maintainer in several DT bindings files.

Let's CC Alexandru Tachici, maybe he knows if we need to update 
and to what.

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Josua Mayer]

Thank you very much for fixing my mistake ... ... fast!

Am 24.05.22 um 17:11 schrieb Geert Uytterhoeven:
> "make dt_binding_check":
> 
>      Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> 
> The first line of the description ends with a colon, hence the block
> needs to be marked with a "|".
> 
> Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml
> index 77750df0c2c45e19..88611720545df2ce 100644
> --- a/Documentation/devicetree/bindings/net/adi,adin.yaml
> +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml
> @@ -37,7 +37,8 @@ properties:
>       default: 8
>   
>     adi,phy-output-clock:
> -    description: Select clock output on GP_CLK pin. Two clocks are available:
> +    description: |
> +      Select clock output on GP_CLK pin. Two clocks are available:
>         A 25MHz reference and a free-running 125MHz.
>         The phy can alternatively automatically switch between the reference and
>         the 125MHz clocks based on its internal state.

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[alexandru.tachici]

> On Tue, 24 May 2022 16:30:18 +0200 Geert Uytterhoeven wrote:
> > On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
> > <geert+renesas@glider.be> wrote:
> > > "make dt_binding_check":
> > >
> > >     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> > >
> > > The first line of the description ends with a colon, hence the block
> > > needs to be marked with a "|".
> > >
> > > Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-  
> > 
> > Alexandru Ardelean's email address bounces, while he is listed as
> > a maintainer in several DT bindings files.
> 
> Let's CC Alexandru Tachici, maybe he knows if we need to update 
> and to what.

Yeah, I should have updated this one. You can add me instead or I will come back with a patch.

  - Alexandru Tachici <alexandru.tachici@analog.com>

Regards,
Alexandru

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Geert Uytterhoeven]

Hi Alexandru,

On Wed, May 25, 2022 at 2:12 PM <alexandru.tachici@analog.com> wrote:
> > On Tue, 24 May 2022 16:30:18 +0200 Geert Uytterhoeven wrote:
> > > On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
> > > <geert+renesas@glider.be> wrote:
> > > > "make dt_binding_check":
> > > >
> > > >     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> > > >
> > > > The first line of the description ends with a colon, hence the block
> > > > needs to be marked with a "|".
> > > >
> > > > Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > >  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
> > >
> > > Alexandru Ardelean's email address bounces, while he is listed as
> > > a maintainer in several DT bindings files.
> >
> > Let's CC Alexandru Tachici, maybe he knows if we need to update
> > and to what.
>
> Yeah, I should have updated this one. You can add me instead or I will come back with a patch.
>
>   - Alexandru Tachici <alexandru.tachici@analog.com>

Please send a patch (or patches).  There are multiple files listing the
bouncing address, and I don't know which devices you have inherited.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[Rob Herring]

On Tue, 24 May 2022 16:11:53 +0200, Geert Uytterhoeven wrote:
> "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> 
> The first line of the description ends with a colon, hence the block
> needs to be marked with a "|".
> 
> Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 24 May 2022 16:11:53 +0200 you wrote:
> "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> 
> The first line of the description ends with a colon, hence the block
> needs to be marked with a "|".
> 
> [...]

Here is the summary with links:
  - dt-bindings: net: adin: Fix adi,phy-output-clock description syntax
    https://git.kernel.org/netdev/net/c/6c465408a770

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html