From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Chris Paterson <Chris.Paterson2@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config
Date: Mon, 4 Jan 2021 15:01:09 +0100 [thread overview]
Message-ID: <CAMuHMdWTtSrK1K9VHoxC+gnSKK82wHx5UyN66rpvnpfm_r7sVQ@mail.gmail.com> (raw)
In-Reply-To: <CA+V-a8uzTWqOGxMVi+ZJwNWRfj9ANxzAqEhLaQLoDiVcwwCUWQ@mail.gmail.com>
Hi Prabhakar,
On Mon, Jan 4, 2021 at 2:38 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Mon, Jan 4, 2021 at 10:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the
> > > description to reflect this.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- a/drivers/net/can/rcar/Kconfig
> > > +++ b/drivers/net/can/rcar/Kconfig
> > > @@ -10,13 +10,13 @@ config CAN_RCAR
> > > be called rcar_can.
> > >
> > > config CAN_RCAR_CANFD
> > > - tristate "Renesas R-Car CAN FD controller"
> > > + tristate "Renesas R-Car Gen3 and RZ/G2 CAN FD controller"
> > > depends on ARCH_RENESAS || ARM
> >
> > Not introduced by this patch, but the "|| ARM" looks strange to me.
> > Is this meant for compile-testing? Doesn't the driver compile on all
> > platforms (it does on m68k), so "|| COMPILE_TEST" is not appropriate?
> > Is the CAN FD controller present on some Renesas arm32 SoCs (but
> > not yet supported by this driver)?
> >
> Good catch. "|| ARM" was probably copied from CAN_RCAR config and I
> can confirm CAN-FD controller doesn't exist on R-Car Gen2 and RZ/G2
G1
> 32bit SoC's (but with a bit of google search RZ/A2M supports CAN-FD I
> am not sure if its the same controller tough), but said that there
Thanks for investigating. I knew about R-Car Gen2 and RZ/G1 not having
CAN-FD.
> shouldn't be any harm in replacing "|| ARM" with "|| COMPILE_TEST"
> for both CAN_RCAR_CAN{FD}. What are your thoughts?
I'd go for "|| COMPILE_TEST".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2021-01-04 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 15:59 [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config Lad Prabhakar
2020-12-31 15:59 ` [PATCH] can: rcar: Update help description for CAN_RCAR config Lad Prabhakar
2021-01-01 17:06 ` Biju Das
2021-01-04 8:46 ` Marc Kleine-Budde
2021-01-04 10:51 ` [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config Geert Uytterhoeven
2021-01-04 13:37 ` Lad, Prabhakar
2021-01-04 14:01 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWTtSrK1K9VHoxC+gnSKK82wHx5UyN66rpvnpfm_r7sVQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).