From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A1FC28CC3 for ; Tue, 4 Jun 2019 07:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92D93249F4 for ; Tue, 4 Jun 2019 07:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbfFDHfd (ORCPT ); Tue, 4 Jun 2019 03:35:33 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:37947 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727146AbfFDHfc (ORCPT ); Tue, 4 Jun 2019 03:35:32 -0400 Received: by mail-lf1-f68.google.com with SMTP id b11so15654308lfa.5; Tue, 04 Jun 2019 00:35:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ObbNbZR/72D98Vc550uzYyGenM0+DWmngeVzeXEi0ZM=; b=ib0Xu1g61kKt4saR39X37LXuWJON+tfn85aLur4B3MXKxOJKsfGcIrueka9ap5bITB GZoaEwnWIFosuMgHN8xJ84pTa1Na4qwF5dIz7HuW1rrERMosDX86L2l8Fh60r2plgffi wygnHVaoMDJdhDTRBf8gJG/cvFPWof0X0UXRFoQAa+4To8SVIiWJPznjo7/KP/ruXsku zWpiEzqudMm+yTj4usuJcPEfEEh4oqWP2FQ7wSx0x0mmb+5SLE5TDO+r2CQgAIxECjqT nvdoPLYYOB4vNCVIsAb67gsneD5g5ExuqyzTCFOlEG4UbJB0UdS8u+UZsAtiga1lSjMJ o1KA== X-Gm-Message-State: APjAAAVEY6okXx8ui8koZ53gOQ05I/nYLdNNnd3RVjefPUInN16wUlQR hNh8DkJbnCcnDZ5xJ575U/aVjDYqHYMjWqjN1mQ= X-Google-Smtp-Source: APXvYqzZy7bAsh6aATIcduZ/ydlM1aKS4jqm+mf9GX84nUleah+LyhiDwD0TYIniqNJly32Ees0tY+eMT6LcuMOqD9Q= X-Received: by 2002:a19:c142:: with SMTP id r63mr17039438lff.49.1559633729962; Tue, 04 Jun 2019 00:35:29 -0700 (PDT) MIME-Version: 1.0 References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-3-geert@linux-m68k.org> <15499.1559298884@warthog.procyon.org.uk> <9306.1559633653@warthog.procyon.org.uk> In-Reply-To: <9306.1559633653@warthog.procyon.org.uk> From: Geert Uytterhoeven Date: Tue, 4 Jun 2019 09:35:16 +0200 Message-ID: Subject: Re: [PATCH] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet() To: David Howells Cc: Igor Konopko , "Mohit P . Tahiliani" , Takashi Sakamoto , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Arnd Bergmann , Dan Carpenter , linux-block@vger.kernel.org, netdev , linux-afs@lists.infradead.org, ALSA Development Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, On Tue, Jun 4, 2019 at 9:34 AM David Howells wrote: > Geert Uytterhoeven wrote: > > > I'm not such a big fan of BUG(), so I'd go for ret = -EAFNOSUPPORT, but given > > rxrpc is already full of BUG() calls, I guess it is an acceptable solution. > > Okay. Are you okay with this going through net-next? Yes, I am. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds