From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
ALeX Kazik <alex@kazik.de>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v5 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver
Date: Sun, 20 Jun 2021 13:47:51 +0200 [thread overview]
Message-ID: <CAMuHMdXPY6w3_rg9nKkiZc1d-bEW84G8xzD0kYEqRiwj6hLWhA@mail.gmail.com> (raw)
In-Reply-To: <5e753883-d8c1-8e2a-9cd8-e6c315862fa2@gmail.com>
Hi Michael,
On Sat, Jun 19, 2021 at 9:31 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> Am 19.06.2021 um 21:08 schrieb Geert Uytterhoeven:
> > On Sat, Jun 19, 2021 at 2:35 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> >> Add Kconfig option, module parameter and PCMCIA reset code
> >> required to support 100 Mbit PCMCIA ethernet cards on Amiga.
> >>
> >> 10 Mbit and 100 Mbit mode are supported by the same module.
> >> A module parameter switches Amiga ISA IO accessors to word
> >> access by changing isa_type at runtime. Additional code to
> >> reset the PCMCIA hardware is also added to the driver probe.
> >>
> >> Patch modified after patch "[PATCH RFC net-next] Amiga PCMCIA
> >> 100 MBit card support" submitted to netdev 2018/09/16 by Alex
> >> Kazik <alex@kazik.de>.
> >>
> >> CC: netdev@vger.kernel.org
> >> Link: https://lore.kernel.org/r/1622958877-2026-1-git-send-email-schmitzmic@gmail.com
> >> Tested-by: Alex Kazik <alex@kazik.de>
> >> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> >
> > Thanks for your patch!
> >
> > Note that this patch has a hard dependency on "[PATCH v5 1/2] m68k:
> > io_mm.h - add APNE 100 MBit support" in the series, so it must not
> > be applied to the netdev tree yet.
>
> Hmm - so we ought to protect the new code by
>
> #ifdef ARCH_HAVE_16BIT_PCMCIA
>
> and set that in the m68k machine Kconfig in the first patch?
>
> (It's almost, but not quite like a config option :-)
No, we just manage dependencies, so either:
1. Patch 2 cannot go in until patch 1 is upstream,
2. One subsystem maintainer gives an Acked-by for one patch,so
the other subsystem maintainer can apply both patches.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-06-20 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1624062891-22762-1-git-send-email-schmitzmic@gmail.com>
2021-06-19 0:34 ` [PATCH net-next v5 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver Michael Schmitz
2021-06-19 0:56 ` Finn Thain
2021-06-19 3:13 ` Michael Schmitz
2021-06-19 9:08 ` Geert Uytterhoeven
2021-06-19 19:31 ` Michael Schmitz
2021-06-20 11:47 ` Geert Uytterhoeven [this message]
2021-06-20 19:36 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXPY6w3_rg9nKkiZc1d-bEW84G8xzD0kYEqRiwj6hLWhA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=alex@kazik.de \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).