Netdev Archive on lore.kernel.org
 help / color / Atom feed
* Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)
       [not found] <20200731211909.33b550ec@canb.auug.org.au>
@ 2020-07-31 15:53 ` Randy Dunlap
  2020-08-01  0:35   ` Stephen Rothwell
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-07-31 15:53 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List
  Cc: Linux Kernel Mailing List, netdev, linux-decnet-user

On 7/31/20 4:19 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200730:
> 

on i386:

ld: net/core/fib_rules.o: in function `fib_rules_lookup':
fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match'
ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match'
ld: fib_rules.c:(.text+0x170d): undefined reference to `fib4_rule_action'
ld: fib_rules.c:(.text+0x171e): undefined reference to `fib4_rule_action'
ld: fib_rules.c:(.text+0x1751): undefined reference to `fib4_rule_suppress'
ld: fib_rules.c:(.text+0x175d): undefined reference to `fib4_rule_suppress'

CONFIG_DECNET=y
CONFIG_DECNET_ROUTER=y

DECNET_ROUTER selects FIB_RULES.


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)
  2020-07-31 15:53 ` linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES) Randy Dunlap
@ 2020-08-01  0:35   ` Stephen Rothwell
  2020-08-01  0:50     ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-08-01  0:35 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, netdev,
	linux-decnet-user, Brian Vazquez, David S. Miller


[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

Hi Randy,

On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386:
> 
> ld: net/core/fib_rules.o: in function `fib_rules_lookup':
> fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match'
> ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match'
> ld: fib_rules.c:(.text+0x170d): undefined reference to `fib4_rule_action'
> ld: fib_rules.c:(.text+0x171e): undefined reference to `fib4_rule_action'
> ld: fib_rules.c:(.text+0x1751): undefined reference to `fib4_rule_suppress'
> ld: fib_rules.c:(.text+0x175d): undefined reference to `fib4_rule_suppress'
> 
> CONFIG_DECNET=y
> CONFIG_DECNET_ROUTER=y
> 
> DECNET_ROUTER selects FIB_RULES.

I assume that CONFIG_IP_MULTIPLE_TABLES was not set for that build?

Caused by commit

  b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")

from the net-next tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)
  2020-08-01  0:35   ` Stephen Rothwell
@ 2020-08-01  0:50     ` Randy Dunlap
  2020-08-01  3:10       ` Brian Vazquez
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-08-01  0:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, netdev,
	linux-decnet-user, Brian Vazquez, David S. Miller

On 7/31/20 5:35 PM, Stephen Rothwell wrote:
> Hi Randy,
> 
> On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> on i386:
>>
>> ld: net/core/fib_rules.o: in function `fib_rules_lookup':
>> fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match'
>> ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match'
>> ld: fib_rules.c:(.text+0x170d): undefined reference to `fib4_rule_action'
>> ld: fib_rules.c:(.text+0x171e): undefined reference to `fib4_rule_action'
>> ld: fib_rules.c:(.text+0x1751): undefined reference to `fib4_rule_suppress'
>> ld: fib_rules.c:(.text+0x175d): undefined reference to `fib4_rule_suppress'
>>
>> CONFIG_DECNET=y
>> CONFIG_DECNET_ROUTER=y
>>
>> DECNET_ROUTER selects FIB_RULES.
> 
> I assume that CONFIG_IP_MULTIPLE_TABLES was not set for that build?

Correct.

> Caused by commit
> 
>   b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")
> 
> from the net-next tree.

thanks.

-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)
  2020-08-01  0:50     ` Randy Dunlap
@ 2020-08-01  3:10       ` Brian Vazquez
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Vazquez @ 2020-08-01  3:10 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, netdev, linux-decnet-user,
	David S. Miller

Ugh I completely missed CONFIG_IP_MULTIPLE_TABLES too, I sent the new
patch. This time I believe I cover all the cases. PTAL.

Thanks,
Brian

On Fri, Jul 31, 2020 at 5:50 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 7/31/20 5:35 PM, Stephen Rothwell wrote:
> > Hi Randy,
> >
> > On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> on i386:
> >>
> >> ld: net/core/fib_rules.o: in function `fib_rules_lookup':
> >> fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match'
> >> ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match'
> >> ld: fib_rules.c:(.text+0x170d): undefined reference to `fib4_rule_action'
> >> ld: fib_rules.c:(.text+0x171e): undefined reference to `fib4_rule_action'
> >> ld: fib_rules.c:(.text+0x1751): undefined reference to `fib4_rule_suppress'
> >> ld: fib_rules.c:(.text+0x175d): undefined reference to `fib4_rule_suppress'
> >>
> >> CONFIG_DECNET=y
> >> CONFIG_DECNET_ROUTER=y
> >>
> >> DECNET_ROUTER selects FIB_RULES.
> >
> > I assume that CONFIG_IP_MULTIPLE_TABLES was not set for that build?
>
> Correct.
>
> > Caused by commit
> >
> >   b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")
> >
> > from the net-next tree.
>
> thanks.
>
> --
> ~Randy
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200731211909.33b550ec@canb.auug.org.au>
2020-07-31 15:53 ` linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES) Randy Dunlap
2020-08-01  0:35   ` Stephen Rothwell
2020-08-01  0:50     ` Randy Dunlap
2020-08-01  3:10       ` Brian Vazquez

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git