From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4AFC433E1 for ; Sat, 1 Aug 2020 03:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD96722BEA for ; Sat, 1 Aug 2020 03:10:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YGHeaopy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbgHADKr (ORCPT ); Fri, 31 Jul 2020 23:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727824AbgHADKq (ORCPT ); Fri, 31 Jul 2020 23:10:46 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72AF0C061756 for ; Fri, 31 Jul 2020 20:10:46 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id o2so15049074qvk.6 for ; Fri, 31 Jul 2020 20:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qnbKMRa0zAhH2ZLCHxKJeQcqF5KDy+gopDBFNWf9shA=; b=YGHeaopyWpWDLXKrlCgqbR5mbkeut5pnAELw0FzoWdN7xZragxD0MZNk/+QvrNZ/c2 6pzKYfC81dsQxIR8S/lFrE77vLfUW0dKl25JEHThgUCdcQR0za56xEcQI0+0Shbso2kd m1i1jYtdV0f4DH7ui189AN9Ei4Te1mbZsRbB2rCpdeUqmtiyfs1W74JpyqpN2rngFtDD 34dk9dHkFHnq12FnA/gyutfxFVmkXTcL3ze3i1WOi/a6kStFBq/VeqBf98aHNMbEylnJ fPsazjefJDs+xSrki4s9ge4N2hZm7GZyUUzKq2IbzXtQZ7Xua2l4x7yjgv3VKCgUOllC r9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qnbKMRa0zAhH2ZLCHxKJeQcqF5KDy+gopDBFNWf9shA=; b=Z85vigB49OAj+lOhHJkaem3n/D//Veps45bxB6Z7G1QvAR7wmb7OwpjBv0+IcuP66t 5VKY0OUlEyhqwnVmO7/pXm0VyXsklTeFnjD4TWPUHidmOrjl3gsU+1ZykHo/yi6vpTde aGnDc9YwEgpF7rCOYMF/DF9ZHP6TZmcL8+9DLeGkxWXIZB+yIFrG4qbZJ6Wsd4cHdDt7 UFgawHgg17dw1WBkjH+TlpNEguxmeU8CXRZHLp1EEymggKiiY3Pi1P9UP7/1/G/jyPuc eGvbWxmaDu5y/osmxGyAFQWmS6gkMHx51ldm+Ey9HPTHlbdQv4h0Klv+KKw0w3Nf4iAn rkcg== X-Gm-Message-State: AOAM532kY61yiRjNOHkls7sg7DKq55m90Oj5BexUtHqW2ZFO+/KCVDpM bgQcMjXs8b9xMuSbVyYxNra5RRtedZLh6oxhIcdcCw== X-Google-Smtp-Source: ABdhPJxxv74V44su6AibvjiFHIXbBoiSD84UvuRcz1CLauN/EnkSZgm5Vd733BgYyNWL+ARVFmG16C2R+BZK65sTGKg= X-Received: by 2002:a0c:fdc5:: with SMTP id g5mr6855641qvs.189.1596251444129; Fri, 31 Jul 2020 20:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20200731211909.33b550ec@canb.auug.org.au> <4c6abcd0-e51b-0cf3-92de-5538c366e685@infradead.org> <20200801103507.03ae069b@canb.auug.org.au> <97853126-c3fb-fced-547f-6dd7d5c89ca9@infradead.org> In-Reply-To: <97853126-c3fb-fced-547f-6dd7d5c89ca9@infradead.org> From: Brian Vazquez Date: Fri, 31 Jul 2020 20:10:32 -0700 Message-ID: Subject: Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES) To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , "netdev@vger.kernel.org" , linux-decnet-user@lists.sourceforge.net, "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Ugh I completely missed CONFIG_IP_MULTIPLE_TABLES too, I sent the new patch. This time I believe I cover all the cases. PTAL. Thanks, Brian On Fri, Jul 31, 2020 at 5:50 PM Randy Dunlap wrote: > > On 7/31/20 5:35 PM, Stephen Rothwell wrote: > > Hi Randy, > > > > On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap wrote: > >> > >> on i386: > >> > >> ld: net/core/fib_rules.o: in function `fib_rules_lookup': > >> fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match' > >> ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match' > >> ld: fib_rules.c:(.text+0x170d): undefined reference to `fib4_rule_action' > >> ld: fib_rules.c:(.text+0x171e): undefined reference to `fib4_rule_action' > >> ld: fib_rules.c:(.text+0x1751): undefined reference to `fib4_rule_suppress' > >> ld: fib_rules.c:(.text+0x175d): undefined reference to `fib4_rule_suppress' > >> > >> CONFIG_DECNET=y > >> CONFIG_DECNET_ROUTER=y > >> > >> DECNET_ROUTER selects FIB_RULES. > > > > I assume that CONFIG_IP_MULTIPLE_TABLES was not set for that build? > > Correct. > > > Caused by commit > > > > b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops") > > > > from the net-next tree. > > thanks. > > -- > ~Randy >