netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Vazquez <brianvv@google.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Brian Vazquez <brianvv.kernel@gmail.com>,
	David Ahern <dsahern@gmail.com>,
	Mahesh Bandewar <maheshb@google.com>,
	Maciej Zenczykowski <maze@google.com>,
	Linux NetDev <netdev@vger.kernel.org>,
	Hritik Vijay <hritikxx8@gmail.com>
Subject: Re: [PATCH iproute2] ss: fix end-of-line printing in misc/ss.c
Date: Wed, 4 Dec 2019 11:39:47 -0800	[thread overview]
Message-ID: <CAMzD94RmG0VE5tcfzASZEC60cFPgcDrbtEXAKsESX3aHTt_qcw@mail.gmail.com> (raw)
In-Reply-To: <20191204111107.4a8d7115@hermes.lan>

Thanks for reviewing it!

On Wed, Dec 4, 2019 at 11:11 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 26 Nov 2019 21:21:18 -0800
> Brian Vazquez <brianvv@google.com> wrote:
>
> > Before commit 5883c6eba517, function field_is_last() was incorrectly
> > reporting which column was the last because it was missing COL_PROC
> > and by purely coincidence it was correctly printing the end-of-line and
> > moving to the first column since the very last field was empty, and
> > end-of-line was added for the last non-empty token since it was seen as
> > the last field.
> >
> > This commits correcrly prints the end-of-line for the last entrien in
> > the ss command.
> >
> > Tested:
> > diff <(./ss.old -nltp) <(misc/ss -nltp)
> > 38c38
> > < LISTEN    0   128     [::1]:35417   [::]:*   users:(("foo",pid=65254,fd=116))
> > \ No newline at end of file
> > ---
> > > LISTEN    0   128     [::1]:35417   [::]:*   users:(("foo",pid=65254,fd=116))
> >
> > Cc: Hritik Vijay <hritikxx8@gmail.com>
> > Fixes: 5883c6eba517 ("ss: show header for --processes/-p")
> > Signed-off-by: Brian Vazquez <brianvv@google.com>
>
> This commit message is really hard to understand and causes warnings
> in checkpatch. Also, blaming old code for doing the right thing
> is not necessary. The changelog doesn't need to explain why.
> The offending commit is already referenced by the fixes line.
>
> Instead, I propose:
>
>
> The previous change to ss to show header broke the printing of end-of-line
> for the last entry.

This makes sense, I'll fix it in next version. Thanks!

>
> Fixes: 5883c6eba517 ("ss: show header for --processes/-p")
> Signed-off-by: Brian Vazquez <brianvv@google.com>

      reply	other threads:[~2019-12-04 19:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  5:21 [PATCH iproute2] ss: fix end-of-line printing in misc/ss.c Brian Vazquez
2019-12-03 13:00 ` Michal Kubecek
2019-12-04 19:11 ` Stephen Hemminger
2019-12-04 19:39   ` Brian Vazquez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMzD94RmG0VE5tcfzASZEC60cFPgcDrbtEXAKsESX3aHTt_qcw@mail.gmail.com \
    --to=brianvv@google.com \
    --cc=brianvv.kernel@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=hritikxx8@gmail.com \
    --cc=maheshb@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).