From: "Maciej Żenczykowski" <maze@google.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Linux NetDev <netdev@vger.kernel.org>,
"John W . Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 02/33] fix unused parameter warnings in do_version() and show_usage()
Date: Mon, 21 Oct 2019 00:17:41 -0700 [thread overview]
Message-ID: <CANP3RGfJJUEm31Qy66et+BWxE40GsaN-XSrtw23rqWgw6CuW1g@mail.gmail.com> (raw)
In-Reply-To: <20191021063122.GC27784@unicorn.suse.cz>
> Considering how frequent this pattern (a callback where not all
> instances use all parameters) is, maybe we could consider disabling the
> warning with -Wno-unused-parameter instead of marking all places where
> it is issued.
Once you fix it... it stays fixed. There's no cost to carrying around
the extra annotation.
And the warning still finds other places where you're doing it wrong.
next prev parent reply other threads:[~2019-10-21 7:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 4:35 Bunch of compiler warning fixes for ethtool Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 01/33] fix arithmetic on pointer to void is a GNU extension warning Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 02/33] fix unused parameter warnings in do_version() and show_usage() Maciej Żenczykowski
2019-10-21 6:31 ` Michal Kubecek
2019-10-21 7:17 ` Maciej Żenczykowski [this message]
2019-10-17 18:20 ` [PATCH 03/33] fix unused parameter warning in find_option() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 04/33] fix unused parameter warning in dump_eeprom() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 05/33] fix unused parameter warning in altera_tse_dump_regs() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 06/33] fix unused parameter warning in sfc_dump_regs() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 07/33] fix unused parameter warning in print_simple_table() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 08/33] fix unused parameter warning in natsemi_dump_regs() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 09/33] fix unused parameter warning in netsemi_dump_eeprom() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 10/33] fix unused parameter warning in ixgbe_dump_regs() Maciej Żenczykowski
2019-10-17 18:20 ` [PATCH 11/33] fix unused parameter warning in realtek_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 12/33] fix unused parameter warning in lan78xx_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 13/33] fix unused parameter warning in {skge,sky2}_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 14/33] fix unused parameter warning in dsa_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 15/33] fix unused parameter warning in vmxnet3_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 16/33] fix unused parameter warning in st_{mac100,gmac}_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 17/33] fix unused parameter warning in ixgbevf_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 18/33] fix unused parameter warning in fec_8xx_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 19/33] fix unused parameter warning in tg3_dump_{eeprom,regs}() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 20/33] fix unused parameter warning in vioc_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 21/33] fix unused parameter warning in e100_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 22/33] fix unused parameter warning in de2104[01]_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 23/33] fix unused parameter warning in igb_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 24/33] fix unused parameter warning in e1000_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 25/33] fix unused parameter warning in smsc911x_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 26/33] fix unused parameter warning in at76c50x_usb_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 27/33] fix unused parameter warning in fec_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 28/33] fix unused parameter warning in amd8111e_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 29/33] fix unused parameter warning in et131x_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 30/33] fix unused parameter warning in ibm_emac_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 31/33] fix unused parameter warning in ixgb_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 32/33] fix unused parameter warning in fjes_dump_regs() Maciej Żenczykowski
2019-10-17 18:21 ` [PATCH 33/33] fix unused parameter warning in e1000_get_mac_type() Maciej Żenczykowski
2019-10-21 6:26 ` [PATCH 01/33] fix arithmetic on pointer to void is a GNU extension warning Michal Kubecek
2019-10-29 17:54 ` Bunch of compiler warning fixes for ethtool John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP3RGfJJUEm31Qy66et+BWxE40GsaN-XSrtw23rqWgw6CuW1g@mail.gmail.com \
--to=maze@google.com \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).