From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFAAC433DF for ; Sat, 23 May 2020 10:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44A2C20727 for ; Sat, 23 May 2020 10:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="LbBFgRwc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387750AbgEWKQO (ORCPT ); Sat, 23 May 2020 06:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgEWKQN (ORCPT ); Sat, 23 May 2020 06:16:13 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4395CC05BD43 for ; Sat, 23 May 2020 03:16:12 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id m12so13235647ljc.6 for ; Sat, 23 May 2020 03:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mIlsCm+rT7kwukl7URSohYQng9/Du2FKvF/brHcNKyU=; b=LbBFgRwcOR6Ca4VmxtLY6AETfa6Cgnvp4i0ehkN6dL7ZYgrj6J93hNdGr6BTTg/2gZ 26Iwme03fRE71vy24tzHeCcP3oe8Vj/n9mRNa8mZHFvBtUlffKPVagv95kiORZ1EiZF6 KrHW9woREVPGdHW6hqk/0Dl9ca4ztL4DhS5zeSxp2qsArsTeg3xsG1h3qc6RypXfOy9S TrNUL48c6pn129JsIF86DTS8GMDwA51qz8JUeLJ+3LEllA1b+RGIERq1oQhZ3kMFqYCE bzduouN192nrwQG7+h6hNQnkb8V8Ly3Dh7JCjHKgw8IF5sAGY/eXf+ImhIpJ02zScS/z 73Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mIlsCm+rT7kwukl7URSohYQng9/Du2FKvF/brHcNKyU=; b=Cirs8txXNj41kYFFOOqon1vxg4WPMhbC7/aBd7jJxXbQoht1+2F+9xn8k2cqh1PgZX kVI3JJDzhGuzUlW7Jt5j6PH+WQsCF8IYh5FxlQIMKMlGlxg7KaICv1Qi9EFSjPhb1p0l o2tNB6pfgam2Q5P0AdQYTmwWuLfOp4B1WPB9RByn/FMo8BS/GOD5A7fx8vkC5+rO9PXl R4ArLEdxYKRQaj4gHZq2ROCW9kkYyQDpv7Krau72FDRdGhi6NnKLgnhyGiKMbioPwFFe 5kGPiUfHb/dO9utc7doFj7RWlORuCiyhGSHcNo7vTOlyzgcZZFyJi2qZZqthqK3SoNwP /+Qg== X-Gm-Message-State: AOAM530OLtiAQkUUZvoNNXy1ssR59Zm8ysSG2eiJW79lhBV5dhtncEzq xXbjK1IJ/6NO+AcpFES5vGjaqEmjOsBtbB132HbiMdA0JRE= X-Google-Smtp-Source: ABdhPJw8d/bvq8DbyNF5EpiICZHfXIYlz3Eh+N9RghL1ws1sCknCrX1LgohK7PlMoVRSX56UsyFqADF4Nqv+onyTp/s= X-Received: by 2002:a2e:6c08:: with SMTP id h8mr7938646ljc.375.1590228970396; Sat, 23 May 2020 03:16:10 -0700 (PDT) MIME-Version: 1.0 References: <1589963516-26703-1-git-send-email-fugang.duan@nxp.com> <1589963516-26703-3-git-send-email-fugang.duan@nxp.com> In-Reply-To: <1589963516-26703-3-git-send-email-fugang.duan@nxp.com> From: "Fuzzey, Martin" Date: Sat, 23 May 2020 12:15:59 +0200 Message-ID: Subject: Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property To: Andy Duan Cc: "David S. Miller" , netdev@vger.kernel.org, Rob Herring , Shawn Guo , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > - gpr: phandle of SoC general purpose register mode. Required for wake on LAN > - on some SoCs > + on some SoCs. Register bits of stop mode control, the format is > + <&gpr req_gpr req_bit>. > + gpr is the phandle to general purpose register node. > + req_gpr is the gpr register offset for ENET stop request. > + req_bit is the gpr bit offset for ENET stop request. > More of a DT binding changes policy question, do we care about supporting the old no argument binding too? I don't think it actually matters seeing as the no argument gpr node binding was only added recently anyway. But it was backported to the stable trees and Documentation/bindings/ABI.txt says "Bindings can be augmented, but the driver shouldn't break when given the old binding. ie. add additional properties, but don't change the meaning of an existing property. For drivers, default to the original behaviour when a newly added property is missing." Myself I think this is overkill in this case and am fine with just changing the binding without the driver handling the old case but that's Rob's call to make I think. Martin