From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE6DC433DF for ; Thu, 4 Jun 2020 11:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A93B2077D for ; Thu, 4 Jun 2020 11:41:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uOadSoLG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbgFDLlX (ORCPT ); Thu, 4 Jun 2020 07:41:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgFDLlU (ORCPT ); Thu, 4 Jun 2020 07:41:20 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63308C03E96D; Thu, 4 Jun 2020 04:41:20 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id n23so6848933ljh.7; Thu, 04 Jun 2020 04:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R0o4OOvzJQjARhQ6/49UmmkOyadJDn2uKBj3nrOAqQo=; b=uOadSoLGhaseNrsSLG0CEfcx1B7ZyXtznA1jW/71TjOkJaQ3v7NhDn32mtbkkPd0Q+ 1UDuNRM26ag+jysBJHImSQ2kyqAxp6Pbe8OVsuK3/X6E6BLOFRucdGoxisc/QkPMQfn9 DSP221R/DYOdjftqL2dmeYiibVPWWApyDr996ybowslc4DnYfcHTAWJ50hppvye4onSW Wki6t+mbrF7ejKkqVkq6hFcUNg4F2aeKBWSYX0y86zDfF0gdQIlIFvOHHUjNdXP4a7ct pto6mvk/UvVFDpzwyBErLblgdgk4M9JUrlkGy+vs2gLKfjfB2m/WaWMIrcXH9QqP6urW FvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R0o4OOvzJQjARhQ6/49UmmkOyadJDn2uKBj3nrOAqQo=; b=P3AAWUXHRD5t3PsW07iHif5KVUnQhGTqfNZ1nMZ/+oBm6ftVVEBgYqOFJpjVXwCYDl 3Bber2Wxs4QJ9bMSg8uM1zAAwd5KMDTHKjJ5tToQVPy+To6oKOA859oNgUJK8Zw7v3ZJ tLvBUVSYzsgMhZSxuFkwM/IDS9xvPeJ0ubRdLYyX/GuoYANchBOmPmPto2+J1FAicESX IwFEZaA8Kuwvd0VQHp2lvzVM2bUaOXxv1Oz1ErDI2qJiW6VI3Z+56JVMCDh3Lqn4miru Uq97hm7jgoQvJJEnmX74CEEcvfU2vTL8t9SDtrY1H3DPv2AYmK27OKcXM8tKGUc8vC1i 2Q8A== X-Gm-Message-State: AOAM533DlaKn9YP6kYlOx2K2g/zk9vvzB2ox9L9un0eEFKvWvmklROQx jdVIiXEOO3oaHch7bgZuSYiBPdo/rz/D4O0M2pc= X-Google-Smtp-Source: ABdhPJxccA+5mnrfVxyneHXrV0mVelE29mG9oDomdWWW1fU5ho8qKcvQdw+EQpyMOql3tRqQBW/MgmXYvs677/gUgQE= X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr2085283ljo.29.1591270878905; Thu, 04 Jun 2020 04:41:18 -0700 (PDT) MIME-Version: 1.0 References: <20200603233203.1695403-2-keescook@chromium.org> <874krr8dps.fsf@nanos.tec.linutronix.de> In-Reply-To: <874krr8dps.fsf@nanos.tec.linutronix.de> From: Miguel Ojeda Date: Thu, 4 Jun 2020 13:41:07 +0200 Message-ID: Subject: Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage To: Thomas Gleixner Cc: Kees Cook , linux-kernel , Linus Torvalds , Alexander Potapenko , Joe Perches , Andy Whitcroft , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, Network Development , linux-wireless , linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, Linux-MM , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 4, 2020 at 9:58 AM Thomas Gleixner wrote: > > but if we ever lose the 1 then the above will silently compile the code > within the IS_ENABLED() section out. Yeah, I believe `IS_ENABLED()` is only meant for Kconfig symbols, not macro defs in general. A better option would be `__is_defined()` which works for defined-to-nothing too. Cheers, Miguel