Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Michael Chan <michael.chan@broadcom.com>,
	Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
	Netdev <netdev@vger.kernel.org>,
	Selvin Xavier <selvin.xavier@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency
Date: Sat, 3 Apr 2021 15:52:13 +0530	[thread overview]
Message-ID: <CANjDDBiuw_VNepewLAtYE58Eg2JEsvGbpxttWyjV6DYMQdY5Zw@mail.gmail.com> (raw)
In-Reply-To: <20210401065715.565226-1-leon@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]

On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Changelog:
> v2:
>  * kbuild spotted that I didn't delete all code in patch #5, so deleted
>    even more ulp_ops derefences.
> v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-leon@kernel.org
>  * Go much deeper and removed useless ULP indirection
> v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org
> -----------------------------------------------------------------------
>
> The following series fixes issue spotted in [1], where bnxt_re driver
> messed with module reference counting in order to implement symbol
> dependency of bnxt_re and bnxt modules. All of this is done, when in
> upstream we have only one ULP user of that bnxt module. The simple
> declaration of exported symbol would do the trick.
>
> This series removes that custom module_get/_put, which is not supposed
> to be in the driver from the beginning and get rid of nasty indirection
> logic that isn't relevant for the upstream code.
>
> Such small changes allow us to simplify the bnxt code and my hope that
> Devesh will continue where I stopped and remove struct bnxt_ulp_ops too.
>
> Thanks
>
> [1] https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org
>
> Leon Romanovsky (5):
>   RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it
>   RDMA/bnxt_re: Create direct symbolic link between bnxt modules
>   RDMA/bnxt_re: Get rid of custom module reference counting
>   net/bnxt: Remove useless check of non-existent ULP id
>   net/bnxt: Use direct API instead of useless indirection
>
>  drivers/infiniband/hw/bnxt_re/Kconfig         |   4 +-
>  drivers/infiniband/hw/bnxt_re/main.c          |  93 ++-----
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |   4 +-
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h     |   1 -
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 245 +++++++-----------
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |  32 +--
>  6 files changed, 119 insertions(+), 260 deletions(-)

Hi Leon,

After a couple of internal discussions we reached a conclusion to
implement the Auxbus driver interface and fix the problem once and for
all.
>
> --
> 2.30.2
>

-- 
-Regards
Devesh

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]