From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D39BC433B4 for ; Sat, 3 Apr 2021 10:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D64FA61220 for ; Sat, 3 Apr 2021 10:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236572AbhDCKWy (ORCPT ); Sat, 3 Apr 2021 06:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236214AbhDCKWx (ORCPT ); Sat, 3 Apr 2021 06:22:53 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB470C0613E6 for ; Sat, 3 Apr 2021 03:22:50 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id by2so3484958qvb.11 for ; Sat, 03 Apr 2021 03:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bILeF9u+pc3M261Et/ObpU7b2e0RCKUCPwKyS5QXwQo=; b=Cyt24oV78qzmQ3MhjK34bWn97b8okBe8gaGtkoCIYaRpsCdAPfKI1IFaUQ5bOLcBp0 ZVRmdjD6Sk2csrhr7F+nK2YzW0tjUhIEyGDJgQM/aWpqQMVfvxiPciJ772Tl0qyJDNb+ bRkbDwJnBuqZ43+fbCSsp0lhkLTQA85UQ0rSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bILeF9u+pc3M261Et/ObpU7b2e0RCKUCPwKyS5QXwQo=; b=knDE//z7MNfbf2k+s1OZ1sOl6sUbMHt9QXIF0j32Eph5IvhhOYZaNpbQU9KqsL0TJP ecC3nzMC24xuQW5NGbOzkv+v8BmITAk0Aa/Xq75HfLiMQomYpiuAcI4UXt5V780hJXtd viWqTfP/AmjJ6r54N4vB2xW7ghgz2Ea/3+LFMc9iM2RBMs9vCxH6zcw//5bnNIrWQNAU G9re6h28eJAp8xqR287ue1f/jyJOmimyt4rLJaBI0pglD9oCOf4arSp19sQz2wdjNBpr PMUJp1QEcyPXLsY4NzWo2g9S6ehIXanN9r8oNwew4pSIxy7RV7pDTujtXEiq3+RcCwkT hEGg== X-Gm-Message-State: AOAM53105bCzyLs6zLUaDjw3W+nGdkTxKiJdTJIFAaoSpdRL4LsJ1fuu AkRcck658uWLPt3w4y1L5QwIKC2FmC4hapr3hs9v7A== X-Google-Smtp-Source: ABdhPJy7YzlO6XD8VMmGX6fT015aeSpYWmSZKC/He/zDlKleAuXQZxygDYhUqWAbdTUL8Utud1d42ZKrOyHvReuwRNA= X-Received: by 2002:a0c:ec11:: with SMTP id y17mr3830014qvo.31.1617445369627; Sat, 03 Apr 2021 03:22:49 -0700 (PDT) MIME-Version: 1.0 References: <20210401065715.565226-1-leon@kernel.org> In-Reply-To: <20210401065715.565226-1-leon@kernel.org> From: Devesh Sharma Date: Sat, 3 Apr 2021 15:52:13 +0530 Message-ID: Subject: Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency To: Leon Romanovsky Cc: Doug Ledford , Jason Gunthorpe , Leon Romanovsky , "David S. Miller" , Jakub Kicinski , linux-rdma , Michael Chan , Naresh Kumar PBS , Netdev , Selvin Xavier , Somnath Kotur , Sriharsha Basavapatna Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000bcab9a05bf0ed842" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --000000000000bcab9a05bf0ed842 Content-Type: text/plain; charset="UTF-8" On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky wrote: > > From: Leon Romanovsky > > Changelog: > v2: > * kbuild spotted that I didn't delete all code in patch #5, so deleted > even more ulp_ops derefences. > v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-leon@kernel.org > * Go much deeper and removed useless ULP indirection > v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org > ----------------------------------------------------------------------- > > The following series fixes issue spotted in [1], where bnxt_re driver > messed with module reference counting in order to implement symbol > dependency of bnxt_re and bnxt modules. All of this is done, when in > upstream we have only one ULP user of that bnxt module. The simple > declaration of exported symbol would do the trick. > > This series removes that custom module_get/_put, which is not supposed > to be in the driver from the beginning and get rid of nasty indirection > logic that isn't relevant for the upstream code. > > Such small changes allow us to simplify the bnxt code and my hope that > Devesh will continue where I stopped and remove struct bnxt_ulp_ops too. > > Thanks > > [1] https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org > > Leon Romanovsky (5): > RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it > RDMA/bnxt_re: Create direct symbolic link between bnxt modules > RDMA/bnxt_re: Get rid of custom module reference counting > net/bnxt: Remove useless check of non-existent ULP id > net/bnxt: Use direct API instead of useless indirection > > drivers/infiniband/hw/bnxt_re/Kconfig | 4 +- > drivers/infiniband/hw/bnxt_re/main.c | 93 ++----- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +- > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 245 +++++++----------- > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 32 +-- > 6 files changed, 119 insertions(+), 260 deletions(-) Hi Leon, After a couple of internal discussions we reached a conclusion to implement the Auxbus driver interface and fix the problem once and for all. > > -- > 2.30.2 > -- -Regards Devesh --000000000000bcab9a05bf0ed842 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDCGDU4mjRUtE1rJIfDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE5MTJaFw0yMjA5MjIxNDUyNDJaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDURldmVzaCBTaGFybWExKTAnBgkqhkiG9w0B CQEWGmRldmVzaC5zaGFybWFAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAqdZbJYU0pwSvcEsPGU4c70rJb88AER0e2yPBliz7n1kVbUny6OTYV16gUCRD8Jchrs1F iA8F7XvAYvp55zrOZScmIqg0sYmhn7ueVXGAxjg3/ylsHcKMquUmtx963XI0kjWwAmTopbhtEBhx 75mMnmfNu4/WTAtCCgi6lhgpqPrted3iCJoAYT2UAMj7z8YRp3IIfYSW34vWW5cmZjw3Vy70Zlzl TUsFTOuxP4FZ9JSu9FWkGJGPobx8FmEvg+HybmXuUG0+PU7EDHKNoW8AcgZvIQYbwfevqWBFwwRD Paihaaj18xGk21lqZcO0BecWKYyV4k9E8poof1dH+GnKqwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpkZXZlc2guc2hhcm1hQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUEe3qNwswWXCeWt/hTDSC KajMvUgwDQYJKoZIhvcNAQELBQADggEBAGm+rkHFWdX4Z3YnpNuhM5Sj6w4b4z1pe+LtSquNyt9X SNuffkoBuPMkEpU3AF9DKJQChG64RAf5UWT/7pOK6lx2kZwhjjXjk9bQVlo6bpojz99/6cqmUyxG PsH1dIxDlPUxwxCksGuW65DORNZgmD6mIwNhKI4Thtdf5H6zGq2ke0523YysUqecSws1AHeA1B3d G6Yi9ScSuy1K8yGKKgHn/ZDCLAVEG92Ax5kxUaivh1BLKdo3kZX8Ot/0mmWvFcjEqRyCE5CL9WAo PU3wdmxYDWOzX5HgFsvArQl4oXob3zKc58TNeGivC9m1KwWJphsMkZNjc2IVVC8gIryWh90xggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwhg1OJo0VLRNay SHwwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIG3naIYfNIMivT3AUiEjvfDz/vjv QNBNG+AoyPpE2JNvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIx MDQwMzEwMjI1MFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQCF+WGYlJ1Tk2jcZKI6iqel/A6C5PTGbxhy2h7Xy2tIT/qT fz9xk7VjJANFLTG0Vzuu2TbxJgSs9UR7+bL9uQYSPjKOzIzm+bk/h1Zhx90VTY3N+H2NGFRhuKz5 P3/pIa9jibtYKXp8qFu746lou4F9s5ewlIa12ZlpVVc0aR4bX+j1Hz+1l8WFic1DKsIzU5hvWR4l x23whrdZEOcPZKNgbmWf0n+Wh5AjIpmCq4kPmmGjAkcnMRFPst6aQznU5fT/jy7U6XBUlDV0msry OnOLLZMYYMyu/TdFPZHVSnpNnAlAJD3WSUMnQWpLbgeaUIxh7r2aT4+w9Cfn1+L9kfM/ --000000000000bcab9a05bf0ed842--