From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F08C43381 for ; Fri, 15 Feb 2019 14:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7905F21A4C for ; Fri, 15 Feb 2019 14:58:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GJRgyKPE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730093AbfBOO6O (ORCPT ); Fri, 15 Feb 2019 09:58:14 -0500 Received: from mail-yb1-f179.google.com ([209.85.219.179]:45333 "EHLO mail-yb1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727231AbfBOO6O (ORCPT ); Fri, 15 Feb 2019 09:58:14 -0500 Received: by mail-yb1-f179.google.com with SMTP id n134so1038199ybg.12 for ; Fri, 15 Feb 2019 06:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QNzxcxtDlTHE1ImR7pN0Q6YEydLfapEBCGie35jnB/4=; b=GJRgyKPEWfr4caPHC5cij2U/jKfMJ3lW7axhJDiCwbnRxYCyoqoLScZfBvNM6wF9MK NszmytqJwF54HXysrCQIvfZ61HdJflm0q3oJ8+gS1P6GXoYn6S8YQQBMk/9AccWCHvdk 8D5iATXY3Wcq9fUMBuDDN8UAP2CE4WbhVlgxHuOoEtG/JONxM6HuLLAw+xUgT/x7q/VM v6ujb0JT0H9V1Zu2IT+jYSn9jv56xMfxUkLSo+qoaIK8vOydorth70ucM/oq3AFmi8c3 maeiA4C5dltb3eM49YWVakoTwR1vtbS+fBVQAjsLnVFEhn7d/V6ygY0MuaKPke8qfpR8 0pfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QNzxcxtDlTHE1ImR7pN0Q6YEydLfapEBCGie35jnB/4=; b=UmwSHxZLbvMvM+Sbs5mr/LcLkPVivoSytdpqB0pL11uHqfwVOfPNaNxifSsN1o3sHw vsmjqDjWSIa3hq2b843WnNUbz5Tk1N93/+RY+QJqzyA4oBNQSvLMM2Gw71mp7LWY6Xmr 4gyNIT3UBXWUnX4Nopu3rLZ3gwHqX7kQhqEKuNO9MbmWa/43ahKEYiTew4E54xYjh82s 0EzJHEOQaMCVLhgwLJXjpaE/mHCnW57SxJoqIN8xy716EXFCfiT3q/WhCUd+vwo2gzE+ wkE9YupTL5fQZ/GFYPn7hrGNoAcUqw0T00hRnc9gWALf6VoK5HL8eFeISfRdBmtLm8iQ MNQg== X-Gm-Message-State: AHQUAubAW3LI+6iNEnQTj1DadHBOGUGFFWWpCNgeBGdqiMfzg4yiuDA+ 8p1Eyn3W+5YPUDyORU4yJLg1E3uawv89BIo/uz2s4HHuaFY= X-Google-Smtp-Source: AHgI3IYxGjZqdSTrWcb/VKyJ/I/Z4xo59bar1CUVEhm905f/USE9pXkLpWihZAV0voNvsYSOW6WC9ZwFkITdqQ8ZfgE= X-Received: by 2002:a25:3004:: with SMTP id w4mr8200579ybw.461.1550242692852; Fri, 15 Feb 2019 06:58:12 -0800 (PST) MIME-Version: 1.0 References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> In-Reply-To: <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> From: Eric Dumazet Date: Fri, 15 Feb 2019 06:58:01 -0800 Message-ID: Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() To: Yafang Shao Cc: David Miller , Daniel Borkmann , netdev , shaoyafang@didiglobal.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote: > > As SOCK_DEBUG() isn't used any more, we can get ride of it now. > No, we are still using this infrastructure from time to time. I told you I agreed to remove the current (obsolete) TCP call sites, I never suggested to remove SOCK_DEBUG() completely.