From: Eric Dumazet <edumazet@google.com>
To: Zheng Li <lizheng043@gmail.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
jmorris@namei.org, pabeni@redhat.com, kuba@kernel.org,
James.Z.Li@dell.com
Subject: Re: [PATCH] neighbour: guarantee the localhost connections be established successfully even the ARP table is full
Date: Tue, 16 Apr 2024 12:02:18 +0200 [thread overview]
Message-ID: <CANn89i+TKbGbmy0JJbyhUxQ9Zc_jj=EHv=bYXT5dUvQY7hw12g@mail.gmail.com> (raw)
In-Reply-To: <20240416095343.540-1-lizheng043@gmail.com>
On Tue, Apr 16, 2024 at 11:54 AM Zheng Li <lizheng043@gmail.com> wrote:
>
> From: Zheng Li <James.Z.Li@Dell.com>
>
> Inter-process communication on localhost should be established successfully
> even the ARP table is full, many processes on server machine use the
> localhost to communicate such as command-line interface (CLI),
> servers hope all CLI commands can be executed successfully even the arp
> table is full. Right now CLI commands got timeout when the arp table is
> full. Set the parameter of exempt_from_gc to be true for LOOPBACK net
> device to keep localhost neigh in arp table, not removed by gc.
>
> the steps of reproduced:
> server with "gc_thresh3 = 1024" setting, ping server from more than 1024
> same netmask Lan IPv4 addresses, run "ssh localhost" on console interface,
> then the command will get timeout.
>
> Signed-off-by: Zheng Li <James.Z.Li@Dell.com>
> ---
> net/core/neighbour.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 552719c3bbc3..47d07b122f7a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -734,7 +734,9 @@ ___neigh_create(struct neigh_table *tbl, const void *pkey,
> struct neighbour *__neigh_create(struct neigh_table *tbl, const void *pkey,
> struct net_device *dev, bool want_ref)
> {
> - return ___neigh_create(tbl, pkey, dev, 0, false, want_ref);
> + bool exempt_from_gc = !!(dev->flags & IFF_LOOPBACK);
> +
> + return ___neigh_create(tbl, pkey, dev, 0, exempt_from_gc, want_ref);
> }
> EXPORT_SYMBOL(__neigh_create);
>
Hmmm...
Loopback IPv4 can hold 2^24 different addresses, that is 16384 * 1024
next prev parent reply other threads:[~2024-04-16 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 9:53 [PATCH] neighbour: guarantee the localhost connections be established successfully even the ARP table is full Zheng Li
2024-04-16 10:02 ` Eric Dumazet [this message]
2024-04-16 10:36 ` Li, James Zheng
2024-04-18 9:33 ` Paolo Abeni
2024-04-18 9:45 ` Eric Dumazet
2024-04-18 10:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2024-04-12 12:25 Zheng Li
2024-04-15 18:07 ` Jakub Kicinski
2024-04-15 18:15 ` Simon Horman
2024-03-11 12:24 Zheng Li
2024-03-11 13:51 ` Ratheesh Kannoth
2024-03-18 8:39 ` James Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89i+TKbGbmy0JJbyhUxQ9Zc_jj=EHv=bYXT5dUvQY7hw12g@mail.gmail.com' \
--to=edumazet@google.com \
--cc=James.Z.Li@dell.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kuba@kernel.org \
--cc=lizheng043@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).