netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Juerg Haefliger <juerg.haefliger@canonical.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Woojung Huh <woojung.huh@microchip.com>
Subject: Re: [Bug 209423] WARN_ON_ONCE() at rtl8169_tso_csum_v2()
Date: Tue, 19 Jan 2021 16:50:10 +0100	[thread overview]
Message-ID: <CANn89i+bQSdos=LKyk=BQdthx1NBXOBVvDBdQQQRAHWL5xc1pQ@mail.gmail.com> (raw)
In-Reply-To: <20210119163800.4859912e@gollum>

On Tue, Jan 19, 2021 at 4:39 PM Juerg Haefliger
<juerg.haefliger@canonical.com> wrote:
>
> On Tue, 19 Jan 2021 14:54:31 +0100
> Eric Dumazet <edumazet@google.com> wrote:
>

> >
> > Oops. Very nice detective work :)
> >
> > It is true that the skb_clone() done in lan78xx (and some other usb
> > drivers) is probably triggering this issue.
> > (lan78xx is also lying about skb->truesize)
> >
> > skb_try_coalesce() bails if the target  skb is cloned, but not if the source is.
> >
> >
> > Can you try the following patch ?
>
> Works. Nice :-)
>

Excellent !

> If you submit this and care you can add:
>
> Tested-by: Juerg Haefliger <juergh@canonical.com>

Sure, I will also add a :

Bisected-by: Juerg Haefliger <juergh@canonical.com>

Because you did quite a lot of work narrowing the problem !

>
> Thanks a lot for the quick turnaround!
>
> ...Juerg
>
>

      reply	other threads:[~2021-01-19 15:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-209423-201211-atteo0d1ZY@https.bugzilla.kernel.org/>
2020-10-01 20:34 ` Fwd: [Bug 209423] WARN_ON_ONCE() at rtl8169_tso_csum_v2() Heiner Kallweit
2020-10-02  8:26   ` Eric Dumazet
2020-10-02  8:32     ` Eric Dumazet
2020-10-02  8:46       ` Eric Dumazet
2020-10-02 11:09         ` Heiner Kallweit
2020-10-02 11:48           ` Eric Dumazet
2020-10-08 16:37             ` Heiner Kallweit
2020-10-08 17:15               ` Eric Dumazet
2020-10-08 18:41                 ` Heiner Kallweit
2020-10-08 18:50                   ` Eric Dumazet
2020-10-08 19:07                     ` Eric Dumazet
2020-10-08 20:54                       ` Heiner Kallweit
2020-10-09  8:29                         ` Eric Dumazet
2021-01-19 12:40                     ` Juerg Haefliger
2021-01-19 13:47                       ` Heiner Kallweit
2021-01-19 13:58                         ` Eric Dumazet
2021-01-19 13:54                       ` Eric Dumazet
2021-01-19 15:38                         ` Juerg Haefliger
2021-01-19 15:50                           ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANn89i+bQSdos=LKyk=BQdthx1NBXOBVvDBdQQQRAHWL5xc1pQ@mail.gmail.com' \
    --to=edumazet@google.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=juerg.haefliger@canonical.com \
    --cc=netdev@vger.kernel.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).