From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D564C43381 for ; Fri, 15 Feb 2019 15:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38EC92190C for ; Fri, 15 Feb 2019 15:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="do4w1wg1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388927AbfBOPzH (ORCPT ); Fri, 15 Feb 2019 10:55:07 -0500 Received: from mail-yb1-f173.google.com ([209.85.219.173]:39781 "EHLO mail-yb1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729485AbfBOPzG (ORCPT ); Fri, 15 Feb 2019 10:55:06 -0500 Received: by mail-yb1-f173.google.com with SMTP id s5so3960009ybp.6 for ; Fri, 15 Feb 2019 07:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2G9XtHesYrHAC0gGiWwKQlC5xZ/Y3fO6DuleY59TNoI=; b=do4w1wg173GX/JZxNEBPQpd976O8Dr2iE+XFvQM/xx4qCxiNLqOLTr2KOcwDfsrW6h LmOPr4TUm8dy+caxSpK1c+A93MYsVuGT/qluV3TXDnkf+lfuK6IfKezyXPLS9cch8SS0 Dqzlq9wUcnsGYb60HlbpFaieixeJXsLlxi7sMQ42o4pXYAmtvAPvkXpxdk/mGasFpyiN Egd1zKFqUJ+y+8Vk4oS1yr9N2pTAPpcMLYjzS03FAdYn1bztzIxI7Sjy3hPzsxjKNzcm nArx/G9OPpJlBdNIMypoJeXLTwIeHvQGZBeCRLZnI4dP6B1s0bVVfz6j2iguCUWkwesX 8SpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2G9XtHesYrHAC0gGiWwKQlC5xZ/Y3fO6DuleY59TNoI=; b=pgZhelqw76SJdG7ZdyXIEsHI5NFMKWvMv559VpxOLPljqDKrtdJgCt3WO4fJ8PVges 6tLTPjHYD+Zd8H1XnAKkln64nPLpQnm9XBHNRV+SohLaVJOsWRDe53fHMeTwy/x3IP0W YqaqQzcdKbaIUHbUHTzUMqfWDAigsQF05skdDkRZBCiOwbW+geXJSQmIK5YUBpb8Jc9X yBDZ4VNXodRmBU6TPy770nBYBrMnpPojmtUzlgmqlH5GuvEvhWkID7GJWBY7ggMQx+dk 86kcVabf+Wh/v0rzBRBqG9sLjb2Q1uji6W5SmX4kH3xMVwIVB4NPMt5F4M6bkbytdM2f 2n+Q== X-Gm-Message-State: AHQUAuY5IFf5ksKO4GBzh1okjeoyiBTx/QHohwaP/FknNAjLz8L86Ue3 EZhWWPoijHE0wpgMjQQRBuM1OVmpmCSDq9h7dKEs2w== X-Google-Smtp-Source: AHgI3Ib1IKZ4HkssDFc17LPOjIlq0MnwDnwoGE1ygLIed3vwrBM3GNyI7Ey0dme/2oBCw/jPBgIFxp6a4D/4txEHJ6o= X-Received: by 2002:a5b:908:: with SMTP id a8mr8433558ybq.127.1550246105566; Fri, 15 Feb 2019 07:55:05 -0800 (PST) MIME-Version: 1.0 References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Eric Dumazet Date: Fri, 15 Feb 2019 07:54:53 -0800 Message-ID: Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() To: Yafang Shao Cc: David Miller , Daniel Borkmann , netdev , shaoyafang@didiglobal.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 7:42 AM Yafang Shao wrote: > > On Fri, Feb 15, 2019 at 10:58 PM Eric Dumazet wrote: > > > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote: > > > > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now. > > > > > > > No, we are still using this infrastructure from time to time. > > > > I told you I agreed to remove the current (obsolete) TCP call sites, > > I never suggested to remove SOCK_DEBUG() completely. > > All right, however I'm not persuaded by you. > Because SOCK_DEBUG() is not a smart way for debugging, which requires > the user code to be modified. > We have other more flexible methords. That might be the case, but only if you get enough privileges and skills. I fail to see why we should enforce anything here. It costs nothing having this interface kept. In any case, we do not deprecate features without a Documentation/ABI/obsolete/* file and quarantine.