From: Eric Dumazet <edumazet@google.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 net-next] inet: remove redundant backlog setting in listen(2)
Date: Tue, 9 Oct 2018 07:00:23 -0700 [thread overview]
Message-ID: <CANn89iK2-5JcaPsq=pV6A8VHDtjd0a0X=23AGyF0GOGbjfPn-w@mail.gmail.com> (raw)
In-Reply-To: <1539086718-4119-1-git-send-email-laoar.shao@gmail.com>
On Tue, Oct 9, 2018 at 5:05 AM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> The sk_max_ack_backlog will be set in the caller inet_listen() and
> dccp_listen_start(), so it is redundant to set it in
> inet_csk_listen_start().
> Just remove this setting.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> net/ipv4/inet_connection_sock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index dfd5009..cdd5c95 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -871,7 +871,6 @@ int inet_csk_listen_start(struct sock *sk, int backlog)
>
> reqsk_queue_alloc(&icsk->icsk_accept_queue);
>
> - sk->sk_max_ack_backlog = backlog;
> sk->sk_ack_backlog = 0;
> inet_csk_delack_init(sk);
You got it wrong again. Can you read my feedbacks one more time ?
This setting is not redundant, unless you move the ones in
inet_listen() and inet_dccp_listen() earlier.
prev parent reply other threads:[~2018-10-09 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 12:05 [PATCH v3 net-next] inet: remove redundant backlog setting in listen(2) Yafang Shao
2018-10-09 12:05 ` [PATCH net-next] tcp: forbid direct reclaim if MSG_DONTWAIT is set in send path Yafang Shao
2018-10-09 14:12 ` Eric Dumazet
2018-10-09 14:52 ` Yafang Shao
2018-10-09 14:58 ` Eric Dumazet
2018-10-09 15:38 ` Eric Dumazet
2018-10-10 1:30 ` Yafang Shao
2018-10-10 1:44 ` Eric Dumazet
2018-10-09 14:00 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iK2-5JcaPsq=pV6A8VHDtjd0a0X=23AGyF0GOGbjfPn-w@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).