From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484BDC43381 for ; Fri, 15 Feb 2019 18:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E55D2192C for ; Fri, 15 Feb 2019 18:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S2l+4PJm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389396AbfBOSWr (ORCPT ); Fri, 15 Feb 2019 13:22:47 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:40198 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389334AbfBOSWq (ORCPT ); Fri, 15 Feb 2019 13:22:46 -0500 Received: by mail-yb1-f194.google.com with SMTP id x13so4143172ybm.7 for ; Fri, 15 Feb 2019 10:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pI20Rzt7SVTOkNRAeCmk38oEE1gd+WKw3Gf+h7Q3iO0=; b=S2l+4PJmY7ardO1ShlqyeBpozq485V1CNtAkKVoPy8z80dZHzBeBR98IJW0OQck1cm 64i+V3gDZ0pbsOPasCxxR0SX37v4Z5bst1zxhBczOK1dltjehdY1kNuiiIZoh5GnPlKO hR7SdOqByMfd9ZOHV1LGFeg+0QtRQBiO5fRrDjTRusL17SdgziFjY+SHt0m/Rrl0vAew a8bF2DqR/lht3BBoe6P9yFHcwW+vMxmTs5EOeoI0gfHy97NXYboupfKHOh3URXIcYPcU GBJuFG2f4zzE2LNsK7Ag/7VFkdlvGsH23eOLOJnw91hfxYlINwprawcrM1IoMe/uHS5J xEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pI20Rzt7SVTOkNRAeCmk38oEE1gd+WKw3Gf+h7Q3iO0=; b=q/f7c3ZTM1tFkXWDPiXD0pn52nBRh48XvpoFyTvVG4RwButjkCdOfoJsNjvz49lUvR PO7kHZ177CPuU+K7SrhktUhv3LLiSTv3E9qLb1mmNO4adpjlsR6pMoOkCGVGeNRJR9Ot HaVJ0xi8LxevSyP0/XWX/4s18/1zjnsZKHJ9VoA0EQxCwJop9bQON/HIdn+f0J87RJfL 33agUsbAI2RWh9NL7O9dEmJEp6XP0/j7tN2dN8KERKiRWjip8M6iuv+UG83t8GTS/g+y CKMg5inK7wuGUeSIuQobJZY0s2suyqvJSCHGw5X0fwYqZKfDBts3vsiopsVMENhkn92p eX0w== X-Gm-Message-State: AHQUAuahHYmlgnd5yJQQu32B3hcx4BYiKhKcyyrbTY2I5CbYGzUm8A6X 3emEeEEH4SczYSps2gq1jUu3+/qgPCIhOIoecXtDheNW1P4= X-Google-Smtp-Source: AHgI3IauSb8zm13BNqbD5OvWlomdPEGz7GT6IXBwaAgC5SL3nnyV9KNUk2CPIjd+u787W0RoEU1yfMHAJDC/QffPQu8= X-Received: by 2002:a25:3004:: with SMTP id w4mr9107112ybw.461.1550254965248; Fri, 15 Feb 2019 10:22:45 -0800 (PST) MIME-Version: 1.0 References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Eric Dumazet Date: Fri, 15 Feb 2019 10:22:33 -0800 Message-ID: Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() To: Cong Wang Cc: Yafang Shao , David Miller , Daniel Borkmann , netdev , shaoyafang@didiglobal.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 10:13 AM Cong Wang wrote: > > On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote: > > > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote: > > > > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now. > > > > > > > No, we are still using this infrastructure from time to time. > > > > I told you I agreed to remove the current (obsolete) TCP call sites, > > I never suggested to remove SOCK_DEBUG() completely. > > Since when do we upstream care about any out-of-tree users? > > You can always carry a patch to keep it downstream if you want, > no one can stop you doing it. Somehow the patch series seems to present things in this way : Eric Dumazet suggested to remove completely the SOCK_DEBUG() interface. I did not. I sometimes am lazy and use SOCK_DEBUG() myself, so I would like we keep it. I know that others are doing the same thing, so I do not feel any shame. Feel free to ignore my feedback.