From: Eric Dumazet <edumazet@google.com>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
"Lorenzo Colitti" <lorenzo@google.com>,
zenczykowski <zenczykowski@gmail.com>,
netdev <netdev@vger.kernel.org>,
"Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH nf] netfilter: ipv6: fix oops when defragmenting locally generated fragments
Date: Tue, 23 Oct 2018 07:54:01 -0700 [thread overview]
Message-ID: <CANn89iKvVNTXBsAV-3EwHaZiV7ZDxpqPM20acJx1t45iwdO1PQ@mail.gmail.com> (raw)
In-Reply-To: <20181023144716.19746-1-fw@strlen.de>
On Tue, Oct 23, 2018 at 7:48 AM Florian Westphal <fw@strlen.de> wrote:
>
> Unlike ipv4 and normal ipv6 defrag, netfilter ipv6 defragmentation did
> not save/restore skb->dst.
>
> This causes oops when handling locally generated ipv6 fragments, as
> output path needs a valid dst.
>
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Fixes: 84379c9afe01 ("netfilter: ipv6: nf_defrag: drop skb dst before queueing")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2018-10-23 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 4:13 crash in xt_policy due to skb_dst_drop() in nf_ct_frag6_gather() Maciej Żenczykowski
2018-10-16 8:11 ` Florian Westphal
2018-10-16 9:40 ` Maciej Żenczykowski
2018-10-16 9:41 ` Maciej Żenczykowski
2018-10-16 9:49 ` Maciej Żenczykowski
2018-10-23 14:47 ` [PATCH nf] netfilter: ipv6: fix oops when defragmenting locally generated fragments Florian Westphal
2018-10-23 14:54 ` Eric Dumazet [this message]
2018-10-23 21:04 ` Maciej Żenczykowski
2018-10-23 22:04 ` Florian Westphal
2018-10-25 8:18 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iKvVNTXBsAV-3EwHaZiV7ZDxpqPM20acJx1t45iwdO1PQ@mail.gmail.com \
--to=edumazet@google.com \
--cc=fw@strlen.de \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).