From: Eric Dumazet <edumazet@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Andreas Roeseler <andreas.a.roeseler@gmail.com>
Subject: Re: [PATCH net-next] net: fix icmp_echo_enable_probe sysctl
Date: Tue, 30 Mar 2021 23:09:21 +0200 [thread overview]
Message-ID: <CANn89iL=LDk4c1YX2MzmauvsRo_XYsO72wRwjX_swDS0N7c7pg@mail.gmail.com> (raw)
In-Reply-To: <20210330210613.2765853-1-eric.dumazet@gmail.com>
On Tue, Mar 30, 2021 at 11:06 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> sysctl_icmp_echo_enable_probe is an u8.
>
> ipv4_net_table entry should use
> .maxlen = sizeof(u8).
> .proc_handler = proc_dou8vec_minmax,
>
I should have added the following tag :
Fixes: f1b8fa9fa586 ("net: add sysctl for enabling RFC 8335 PROBE messages")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Andreas Roeseler <andreas.a.roeseler@gmail.com>
> ---
> net/ipv4/sysctl_net_ipv4.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index e3cb2d96b55e99f4322a99abb6a6da866dffcf4d..9199f507a005efc3f57ca0225d3898bfa5d01c53 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
> @@ -601,9 +601,9 @@ static struct ctl_table ipv4_net_table[] = {
> {
> .procname = "icmp_echo_enable_probe",
> .data = &init_net.ipv4.sysctl_icmp_echo_enable_probe,
> - .maxlen = sizeof(int),
> + .maxlen = sizeof(u8),
> .mode = 0644,
> - .proc_handler = proc_dointvec_minmax,
> + .proc_handler = proc_dou8vec_minmax,
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE
> },
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
next prev parent reply other threads:[~2021-03-30 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 21:06 [PATCH net-next] net: fix icmp_echo_enable_probe sysctl Eric Dumazet
2021-03-30 21:09 ` Eric Dumazet [this message]
2021-03-31 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iL=LDk4c1YX2MzmauvsRo_XYsO72wRwjX_swDS0N7c7pg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).