From: Eric Dumazet <edumazet@google.com>
To: Enke Chen <enkechen2020@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes
Date: Fri, 22 Jan 2021 21:41:27 +0100 [thread overview]
Message-ID: <CANn89iLBvwmRbbgw=U3z8k+i_S-ycSf7K-ow4rH5ZQP9CFJuWQ@mail.gmail.com> (raw)
In-Reply-To: <20210122191306.GA99540@localhost.localdomain>
On Fri, Jan 22, 2021 at 8:13 PM Enke Chen <enkechen2020@gmail.com> wrote:
>
> From: Enke Chen <enchen@paloaltonetworks.com>
>
> The TCP_USER_TIMEOUT is checked by the 0-window probe timer. As the
> timer has backoff with a max interval of about two minutes, the
> actual timeout for TCP_USER_TIMEOUT can be off by up to two minutes.
>
> In this patch the TCP_USER_TIMEOUT is made more accurate by taking it
> into account when computing the timer value for the 0-window probes.
>
> This patch is similar to the one that made TCP_USER_TIMEOUT accurate for
> RTOs in commit b701a99e431d ("tcp: Add tcp_clamp_rto_to_user_timeout()
> helper to improve accuracy").
>
> Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
> Reviewed-by: Neal Cardwell <ncardwell@google.com>
> ---
SGTM, thanks !
Signed-off-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2021-01-22 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 19:13 [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes Enke Chen
2021-01-22 20:41 ` Eric Dumazet [this message]
2021-01-23 1:43 ` Jakub Kicinski
2021-01-23 2:28 ` Enke Chen
2021-01-23 2:34 ` Jakub Kicinski
2021-01-23 2:45 ` Enke Chen
2021-01-24 0:19 ` Neal Cardwell
2021-01-24 0:56 ` Enke Chen
2021-01-24 3:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLBvwmRbbgw=U3z8k+i_S-ycSf7K-ow4rH5ZQP9CFJuWQ@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=enkechen2020@gmail.com \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).