Re: [PATCH v8 net-next 2/5] cache: enforce cache groups

From: Eric Dumazet <edumazet@google.com>
To: Coco Li <lixiaoyan@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	 Mubashir Adnan Qureshi <mubashirq@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
	 Jonathan Corbet <corbet@lwn.net>,
	David Ahern <dsahern@kernel.org>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org, Chao Wu <wwchao@google.com>,
	 Wei Wang <weiwan@google.com>,
	Pradeep Nemavat <pnemavat@google.com>
Subject: Re: [PATCH v8 net-next 2/5] cache: enforce cache groups
Date: Thu, 30 Nov 2023 11:40:43 +0100	[thread overview]
Message-ID: <CANn89iLDSUKBr_trZFgkFPfCGXvTRPcaaZvh0tZd=DE4RHJ9rA@mail.gmail.com> (raw)
In-Reply-To: <20231129072756.3684495-3-lixiaoyan@google.com>

On Wed, Nov 29, 2023 at 8:28 AM Coco Li <lixiaoyan@google.com> wrote:
>
> Set up build time warnings to safeguard against future header changes of
> organized structs.
>
> Warning includes:
>
> 1) whether all variables are still in the same cache group
> 2) whether all the cache groups have the sum of the members size (in the
>    maximum condition, including all members defined in configs)
>
> The __cache_group* variables are ignored in kernel-doc check in the
> various header files they appear in to enforce the cache groups.
>
> Suggested-by: Daniel Borkmann <daniel@iogearbox.net>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
>  include/linux/cache.h | 25 +++++++++++++++++++++++++
>  scripts/kernel-doc    |  5 +++++
>  2 files changed, 30 insertions(+)
>

Reviewed-by: Eric Dumazet <edumazet@google.com>