From: Eric Dumazet <edumazet@google.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Shachar Kagan <skagan@nvidia.com>,
netdev@vger.kernel.org, Bagas Sanjaya <bagasdotme@gmail.com>,
"Linux regression tracking (Thorsten Leemhuis)"
<regressions@leemhuis.info>
Subject: Re: [PATCH net-next] tcp: Revert no longer abort SYN_SENT when receiving some ICMP
Date: Tue, 2 Jan 2024 11:03:55 +0100 [thread overview]
Message-ID: <CANn89iLd6EeC3b8DTXBP=cDw8ri+k_uGiCrAS6BOoG3FMuAxmg@mail.gmail.com> (raw)
In-Reply-To: <20240102095835.GF6361@unreal>
On Tue, Jan 2, 2024 at 10:58 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Tue, Jan 02, 2024 at 10:46:13AM +0100, Eric Dumazet wrote:
> > On Tue, Jan 2, 2024 at 10:01 AM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > From: Shachar Kagan <skagan@nvidia.com>
> > >
> > > This reverts commit 0a8de364ff7a14558e9676f424283148110384d6.
> > >
> > > Shachar reported that Vagrant (https://www.vagrantup.com/), which is
> > > very popular tool to manage fleet of VMs stopped to work after commit
> > > citied in Fixes line.
> > >
> > > The issue appears while using Vagrant to manage nested VMs.
> > > The steps are:
> > > * create vagrant file
> > > * vagrant up
> > > * vagrant halt (VM is created but shut down)
> > > * vagrant up - fail
> > >
> >
> > I would rather have an explanation, instead of reverting a valid patch.
> >
> > I have been on vacation for some time. I may have missed a detailed
> > explanation, please repost if needed.
>
> Our detailed explanation that revert worked. You provided the patch that
> broke, so please let's not require from users to debug it.
>
> If you need a help to reproduce and/or test some hypothesis, Shachar
> will be happy to help you, just ask.
I have asked already, and received files that showed no ICMP relevant
interactions.
Can someone from your team help Shachar to get a packet capture of
both TCP _and_ ICMP packets ?
Otherwise there is little I can do. I can not blindly trust someone
that a valid patch broke something, just because 'something broke'
next prev parent reply other threads:[~2024-01-02 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 9:00 [PATCH net-next] tcp: Revert no longer abort SYN_SENT when receiving some ICMP Leon Romanovsky
2024-01-02 9:46 ` Eric Dumazet
2024-01-02 9:58 ` Leon Romanovsky
2024-01-02 10:03 ` Eric Dumazet [this message]
2024-01-02 10:11 ` Eric Dumazet
2024-01-02 11:41 ` Leon Romanovsky
2024-01-02 15:31 ` Eric Dumazet
2024-01-02 18:01 ` Leon Romanovsky
2024-01-02 18:33 ` Eric Dumazet
2024-01-02 19:13 ` Leon Romanovsky
2024-01-02 22:02 ` Jakub Kicinski
2024-01-03 6:00 ` Leon Romanovsky
2024-01-08 15:52 ` Eric Dumazet
2024-01-09 13:26 ` Leon Romanovsky
2024-01-09 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLd6EeC3b8DTXBP=cDw8ri+k_uGiCrAS6BOoG3FMuAxmg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=skagan@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).