From: Eric Dumazet <edumazet@google.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Wei Wang <weiwan@google.com>
Subject: Re: [PATCH net v2] net: fix hangup on napi_disable for threaded napi
Date: Fri, 9 Apr 2021 17:52:33 +0200 [thread overview]
Message-ID: <CANn89iLiZZeomS2yBh7OXmu_zrxfZt8soebD+XUcJq0f6wH=vg@mail.gmail.com> (raw)
In-Reply-To: <385f1818-911e-4c7d-1501-8710691d609a@gmail.com>
On Fri, Apr 9, 2021 at 5:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
>
> Unrelated to the actual issue:
> I wonder why -1 is returned, that's unusual in kernel. The return value
> is used as bool, so why not return a bool?
This is a leftover of a prior implementation that returned 3 values.
No bug here really, this is a matter of taste I suppose.
next prev parent reply other threads:[~2021-04-09 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 15:24 [PATCH net v2] net: fix hangup on napi_disable for threaded napi Paolo Abeni
2021-04-09 15:28 ` Eric Dumazet
2021-04-09 15:35 ` Heiner Kallweit
2021-04-09 15:52 ` Eric Dumazet [this message]
2021-04-09 20:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLiZZeomS2yBh7OXmu_zrxfZt8soebD+XUcJq0f6wH=vg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).