From: Eric Dumazet <edumazet@google.com>
To: Florian Westphal <fw@strlen.de>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] ipv6: drop incoming packets having a v4mapped source address
Date: Wed, 2 Oct 2019 11:47:04 -0700 [thread overview]
Message-ID: <CANn89iLsrAm80Snk9YzEASWtrskqWFpEU11Y253pt1S=75B4wA@mail.gmail.com> (raw)
In-Reply-To: <20191002183856.GA13866@breakpoint.cc>
On Wed, Oct 2, 2019 at 11:38 AM Florian Westphal <fw@strlen.de> wrote:
>
> Eric Dumazet <edumazet@google.com> wrote:
> > The dual stack API automatically forces the traffic to be IPv4
> > if v4mapped addresses are used at bind() or connect(), so it makes
> > no sense to allow IPv6 traffic to use the same v4mapped class.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Cc: Florian Westphal <fw@strlen.de>
> > Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
> > Reported-by: syzbot <syzkaller@googlegroups.com>
> > ---
> > net/ipv6/ip6_input.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
> > index d432d0011c160f41aec09640e95179dd7b364cfc..2bb0b66181a741c7fb73cacbdf34c5160f52d186 100644
> > --- a/net/ipv6/ip6_input.c
> > +++ b/net/ipv6/ip6_input.c
> > @@ -223,6 +223,16 @@ static struct sk_buff *ip6_rcv_core(struct sk_buff *skb, struct net_device *dev,
> > if (ipv6_addr_is_multicast(&hdr->saddr))
> > goto err;
> >
> > + /* While RFC4291 is not explicit about v4mapped addresses
> > + * in IPv6 headers, it seems clear linux dual-stack
> > + * model can not deal properly with these.
> > + * Security models could be fooled by ::ffff:127.0.0.1 for example.
> > + *
> > + * https://tools.ietf.org/html/draft-itojun-v6ops-v4mapped-harmful-02
> > + */
> > + if (ipv6_addr_v4mapped(&hdr->saddr))
> > + goto err;
> > +
>
> Any reason to only consider ->saddr instead of checking daddr as well?
I do not see reasons the packet should be accepted for sane configurations ?
I would rather have a separate patch for daddr if someone needs it.
(This also comes at a cpu cost for all received packets :/ )
next prev parent reply other threads:[~2019-10-02 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 16:38 [PATCH net] ipv6: drop incoming packets having a v4mapped source address Eric Dumazet
2019-10-02 18:38 ` Florian Westphal
2019-10-02 18:47 ` Eric Dumazet [this message]
2019-10-02 21:54 ` Florian Westphal
2019-10-03 15:42 ` David Miller
2021-03-05 17:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLsrAm80Snk9YzEASWtrskqWFpEU11Y253pt1S=75B4wA@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).