From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDAD5C55178 for ; Tue, 27 Oct 2020 12:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8293D21D7B for ; Tue, 27 Oct 2020 12:31:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BNIE5eBY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2899956AbgJ0Mbg (ORCPT ); Tue, 27 Oct 2020 08:31:36 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:39875 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2411811AbgJ0Mbf (ORCPT ); Tue, 27 Oct 2020 08:31:35 -0400 Received: by mail-il1-f195.google.com with SMTP id q1so1317460ilt.6 for ; Tue, 27 Oct 2020 05:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NX3aMd8nOxmdYv1FMvBjyoMjhVdlhBSOsPMwKR/CR38=; b=BNIE5eBYuI7rcpMZ7Fc8fXqliKjnQxcjorZNJL1u/wBpIhZBPNm/oj2C1C6ZdxZGqP uAYGC/mtPEyUM4jNLBnAm4jxr4genpcgGd/TQ/ERBwsmskt1N17w//1kmUAuHUDUnICN NTh72+99x21FAoc2Rb5wYJc0zP7/BuMc6mdP6YIeVMTXUp09DbbKqxyiR0QbSxt9Uh9M PDmkAegg3yxK47MX7sNkSW2kPFFGSzm9nBayI2anXHD4KkqoCRkjPLjI9snUHdRjVihA 3vXx/MIX6pic4UTKz+mgxXOAbcTQne8C0eTtk/Ce5Xpl2con9KqsduAuDGrmvbvUEpCw 056w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NX3aMd8nOxmdYv1FMvBjyoMjhVdlhBSOsPMwKR/CR38=; b=DAdIvceuk/OMRNXsO5qYLVDk83aqaxgejU9rKRqQNqFLiaTW04f46YaEPF7EcuOQKP A0JOPA369KSMws2wp4/sgdqGQKG5Ihntmfbb/GWwjC7prMItKT8ZFZVcir/GHtL+N0tA 0lyNvma3YpLYNpCtKWu8Uj50mwXR1+ZuzOus1FbVphEfcXUQW9KhiXOXLyRienSFDqyg CZXwwQDPzPsjT71Tz4cQ2mOyJl+fIR2D5/bjhqh7ErFlNUfe6RijiPufvhl1iyr9m/XW dp6a8B4qGVmmcMriKDfXc5QpvOZkb52cYbGnWe6eZF9KuigRcZ0/nzv5kVnpAgZHC/KQ 8hyw== X-Gm-Message-State: AOAM533U8qjqJt4aKL5rvk3BzwBO0I1EyV24VNtOdHR9DNKUzklgpsUQ mlqi4LzTSvXXHpGmM8mI4hb16HCUtCIRCPSss1RBRA== X-Google-Smtp-Source: ABdhPJwb/TNwFu+jrjo/IlYtjsGVcMMEoaPtXivWlxQC5lx3nfvrKZa3AsaqBYz1meb28HW+GVasVy0wuSu9kPRfM0A= X-Received: by 2002:a92:6504:: with SMTP id z4mr1446561ilb.282.1603801894156; Tue, 27 Oct 2020 05:31:34 -0700 (PDT) MIME-Version: 1.0 References: <20201026150851.528148-1-aleksandrnogikh@gmail.com> <20201026150851.528148-3-aleksandrnogikh@gmail.com> In-Reply-To: From: Aleksandr Nogikh Date: Tue, 27 Oct 2020 15:31:23 +0300 Message-ID: Subject: Re: [PATCH v3 2/3] net: add kcov handle to skb extensions To: Willem de Bruijn Cc: Aleksandr Nogikh , David Miller , Jakub Kicinski , Johannes Berg , Eric Dumazet , Andrey Konovalov , Dmitry Vyukov , Marco Elver , linux-kernel , Network Development , linux-wireless Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 26, 2020 at 7:57 PM Willem de Bruijn wrote: [...] > If the handle does not need to be set if zero, why then set it if the > skb has extensions? The point of that condition is to avoid unnecessary allocations of skb exte= nsion objects. At the same time, one would expect skb_get_kcov_handle to return t= he latest value that was set via skb_set_kcov_handle. So if a buffer already h= as a non-zero kcov_handle and skb_set_kcov_handle is called to set it to zero, i= t should be set to zero. > skb_ext_add and skb_ext_find are not defined unless CONFIG_SKB_EXTENSIONS= . > > Perhaps CONFIG_KCOV should be made to select that? Yes, thank you for pointing it out. I=E2=80=99ll fix it in the next version= .