From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31773C56201 for ; Wed, 25 Nov 2020 16:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C42C92145D for ; Wed, 25 Nov 2020 16:30:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pCjIkr08" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731183AbgKYQaT (ORCPT ); Wed, 25 Nov 2020 11:30:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730619AbgKYQaS (ORCPT ); Wed, 25 Nov 2020 11:30:18 -0500 Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 443C3C061A4F for ; Wed, 25 Nov 2020 08:30:18 -0800 (PST) Received: by mail-oo1-xc44.google.com with SMTP id y3so621160ooq.2 for ; Wed, 25 Nov 2020 08:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u2ymb6kphenbYa9NqBfUSs5w3DhdYrXoLEdK5gIrDe4=; b=pCjIkr08b2JNL/em/FgTdQ6lsR/OmEC306joPof9QfgAPqdwSgF9s6u7INeZaoJQv2 hloN19U0M+R04BAIpi6uzXJKEHAD8xH7peMPFUOFAl4Nc9ni1KTfTze7hsdbGcairdlY wUj4N7pMoWMm9oCHP/YtBz7FOGRIjyFqKko9J8Mrv0mgKdgsNUNmunGubxSPGZgFKyiZ 8GetxyC8WtIPq5T8K/WoB5uKeHAs93S2bRI8z9Pbi87k466zhCV4RmREbkydyWkSnxr/ 10/XzMTReGwC8CDy/Apnr1w0U4s4yiVzErpeo59puaM/4jmLxMbFzY82k0kCaYVmstft ZwbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u2ymb6kphenbYa9NqBfUSs5w3DhdYrXoLEdK5gIrDe4=; b=twTXxJJmnEUojoNzNZObvEe96TYimzFjXMkpZkVxPimGuIerOkmwD5aWC/7cyF+rwv jk927GkyetQBYrD7fO6EuI8LGwcGkTEGpchmt1xwbgZrSaJGcjLgnxMHIgfWu7xFtL7U iw0cdzguPNrzHZFm54dyIPY7OxiLJGwfU9vOCfeYVVg5JOaHshV+LrKUUueCjxfxsebP jbwQQTgnxELDhfYioS39qOQ8ntxchU+/+iJrD/UKgK5KR0Olenl8x9jfgP3hn6+eoxMU LFiXtExXrQnfBnsVeqxgGSArdKnuBsQO4n2jaU95iDC1JzvbzLeeh9gKwJoESkJ4JHUt ZeoQ== X-Gm-Message-State: AOAM532ayC+kpdXAtJ0GzPKuLtmHEA0IvRQabB7snj5+IttR/ogEtXtD CJWL5muNIa0Xb1nLY612iYXsuJNS/LU/DpnoXy6AkA== X-Google-Smtp-Source: ABdhPJyvUAUS2PQ3HfaYjg7qyRIj/80oKoHdVzEk1YjEWjiFajYFbOrcbDV631NIDei82VfRcJvgUrOuwYtwM+VoN6o= X-Received: by 2002:a4a:b28b:: with SMTP id k11mr3299006ooo.54.1606321815976; Wed, 25 Nov 2020 08:30:15 -0800 (PST) MIME-Version: 1.0 References: <20201029173620.2121359-1-aleksandrnogikh@gmail.com> <20201029173620.2121359-3-aleksandrnogikh@gmail.com> <20201121160941.GA485907@shredder.lan> <20201121165227.GT15137@breakpoint.cc> <20201121100636.26aaaf8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201121103529.4b4acbff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <106fc65f0459bc316e89beaf6bd71e823c4c01b7.camel@sipsolutions.net> <20201121125508.4d526dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <86c6369a937c760e374c78f5252ffc67cf67b1e1.camel@sipsolutions.net> <20201121130227.5136221c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201121130227.5136221c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Marco Elver Date: Wed, 25 Nov 2020 17:30:04 +0100 Message-ID: Subject: Re: [PATCH v5 2/3] net: add kcov handle to skb extensions To: Jakub Kicinski Cc: Johannes Berg , Florian Westphal , Ido Schimmel , Aleksandr Nogikh , "David S. Miller" , Eric Dumazet , Andrey Konovalov , Dmitry Vyukov , LKML , Netdev , linux-wireless@vger.kernel.org, willemdebruijn.kernel@gmail.com, Aleksandr Nogikh , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 21 Nov 2020 at 22:02, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 21:58:37 +0100 Johannes Berg wrote: > > On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote: > > > It is more complicated. We can go back to an skb field if this work is > > > expected to yield results for mac80211. Would you mind sending a patch? > > > > I can do that, but I'm not going to be able to do it now/tonight (GMT+1 > > here), so probably only Monday/Tuesday or so, sorry. > > Oh yea, no worries, took someone a month to notice this is broken, > as long as it's fixed before the merge window it's fine ;) I took the liberty of taking patch 2/3 from v2 which was still storing kcov_handle in sk_buff, and resending with the updates to patch 3/3: https://lkml.kernel.org/r/20201125162455.1690502-1-elver@google.com Thanks, -- Marco