From: "Václav Zindulka" <vaclav.zindulka@tlapnet.cz>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: iproute2: tc deletion freezes whole server
Date: Tue, 5 May 2020 10:46:05 +0200 [thread overview]
Message-ID: <CANxWus-9gjCvMw7ctG7idERsZd7WtObRs4iuTUp_=AaJtHbSgg@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpV_ebQjZuwhxhHSatcjNXzGBgz0JDC+H-nO-dXRkPKKUQ@mail.gmail.com>
On Mon, May 4, 2020 at 7:46 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> Sorry for the delay. I lost connection to my dev machine, I am trying
> to setup this on my own laptop.
Sorry to hear that. I will gladly give you access to my testing
machine where all this nasty stuff happens every time so you can test
it in place. You can try everything there and have online results. I
can give you access even to the IPMI console so you can switch the
kernel during boot easily. I didn't notice this problem until the time
of deployment. My prior testing machines were with metallic ethernet
ports only so I didn't know about those problems earlier.
> On Mon, May 4, 2020 at 10:36 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > Regarding to your test result above, I think I saw some difference
> > on my side, I have no idea why you didn't see any difference. Please
> > let me collect the data once I setup the test environment shortly today.
I saw some improvement too. It was more than 1.5s faster. Yet it was
still over 21s. I measured it with perf trace, not with time. I'll try
it the same way as you did.
>
> I tried to emulate your test case in my VM, here is the script I use:
>
> ====
> ip li set dev dummy0 up
> tc qd add dev dummy0 root handle 1: htb default 1
> for i in `seq 1 1000`
> do
> tc class add dev dummy0 parent 1:0 classid 1:$i htb rate 1mbit ceil 1.5mbit
> tc qd add dev dummy0 parent 1:$i fq_codel
> done
>
> time tc qd del dev dummy0 root
> ====
>
> And this is the result:
>
> Before my patch:
> real 0m0.488s
> user 0m0.000s
> sys 0m0.325s
>
> After my patch:
> real 0m0.180s
> user 0m0.000s
> sys 0m0.132s
My results with your test script.
before patch:
/usr/bin/time -p tc qdisc del dev enp1s0f0 root
real 1.63
user 0.00
sys 1.63
after patch:
/usr/bin/time -p tc qdisc del dev enp1s0f0 root
real 1.55
user 0.00
sys 1.54
> This is an obvious improvement, so I have no idea why you didn't
> catch any difference.
We use hfsc instead of htb. I don't know whether it may cause any
difference. I can provide you with my test scripts if necessary.
Thank you.
next prev parent reply other threads:[~2020-05-05 8:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 18:06 iproute2: tc deletion freezes whole server Václav Zindulka
2020-03-23 18:17 ` Cong Wang
2020-03-24 16:27 ` Václav Zindulka
2020-03-24 22:57 ` Cong Wang
2020-03-25 11:27 ` Václav Zindulka
2020-03-25 13:33 ` Václav Zindulka
2020-03-25 17:43 ` Cong Wang
2020-03-25 18:23 ` Václav Zindulka
2020-03-26 14:24 ` Václav Zindulka
2020-03-26 17:07 ` Cong Wang
2020-03-26 17:38 ` Cong Wang
2020-03-27 10:35 ` Václav Zindulka
2020-03-28 13:04 ` Václav Zindulka
2020-03-31 5:59 ` Cong Wang
2020-03-31 12:46 ` Václav Zindulka
2020-04-08 20:18 ` Cong Wang
2020-04-12 20:17 ` Václav Zindulka
2020-04-13 17:28 ` Cong Wang
2020-04-15 15:01 ` Václav Zindulka
2020-04-30 12:40 ` Václav Zindulka
2020-05-04 17:46 ` Cong Wang
2020-05-04 20:36 ` Cong Wang
2020-05-05 8:46 ` Václav Zindulka [this message]
2020-05-07 18:52 ` Cong Wang
2020-05-08 13:59 ` Václav Zindulka
2020-05-17 19:35 ` Cong Wang
2020-05-18 14:16 ` Václav Zindulka
2020-05-18 18:22 ` Cong Wang
2020-05-19 8:04 ` Václav Zindulka
2020-05-19 17:56 ` Cong Wang
2020-05-24 10:03 ` Václav Zindulka
2020-05-26 18:37 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANxWus-9gjCvMw7ctG7idERsZd7WtObRs4iuTUp_=AaJtHbSgg@mail.gmail.com' \
--to=vaclav.zindulka@tlapnet.cz \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).