From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED7BC433EF for ; Sat, 5 Mar 2022 10:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbiCEKIN (ORCPT ); Sat, 5 Mar 2022 05:08:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbiCEKIK (ORCPT ); Sat, 5 Mar 2022 05:08:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6FF7425C128 for ; Sat, 5 Mar 2022 02:07:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646474838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a0Fgc88E/ZnztbMYK2n/3xkvK5J7VCgRYmi3UI+KKPI=; b=EQrcV1RngVR5eUbfS2dgxmuc8SYZRCtPitexg/fdWpbtPZjqYmzv0D3SwI/WQN/+CG24Fp qgYiO31q68r9j7sANSvKfQBz/w04ttcabOHIm52l6vs5K+WVkjtBhFs+KbTw8BdYzKXx5E +jtAwQJWyPQRZy39BhDguIJ/+j+yd3o= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-laYm5U8DO4uqeTKP2zIrfw-1; Sat, 05 Mar 2022 05:07:17 -0500 X-MC-Unique: laYm5U8DO4uqeTKP2zIrfw-1 Received: by mail-pj1-f69.google.com with SMTP id lp2-20020a17090b4a8200b001bc449ecbceso8893389pjb.8 for ; Sat, 05 Mar 2022 02:07:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a0Fgc88E/ZnztbMYK2n/3xkvK5J7VCgRYmi3UI+KKPI=; b=oqB9WCfHqcVxbyjmIJpgmSwB84Br/tFPIU6b4NA0wd5vRPfDfT2rKF/nnMrWaqT11u 1z/m5YCWAk3T44fc7G+JWqHPORPWMuXrF5P5kduj7TpfI5GvsWoc3yII9FTFcejRZTLO /tVY7L/b8hlu2sjZunMF9PLiTHfe0gm+VO+MeCTxYe8S5H2KwdQ674yRjc+cZKGgXklP 4r7yHVCDFdGOYTj0qKP+STEkEyHIHI70qNATtfWd+zHgCWlQrltAyOfHDHEdEJjk4bcp 5k4rdvsG7y2aDc4rAtv4DnWV0UkzKft89qrJ1RTy2d/L/54Djgg1VqUMUIjzRUST9Teu X+VA== X-Gm-Message-State: AOAM533HpUDJfKwH5f4c0Ix7sQPhGSf/Dh59RUpdk3aJTvaHLUnal3Ne rZYe6RJxeTBG9lzOibrpFlV3d02OJ9fkc+TNachAiz5cZQobvr2xBUq2iK6iOn+4ux2F7KozMWa 8OZvzNT+rBquBkMFDcPLZ191wADC6jCAj X-Received: by 2002:a17:90a:dac2:b0:1bd:fecf:6bd1 with SMTP id g2-20020a17090adac200b001bdfecf6bd1mr3049404pjx.113.1646474835971; Sat, 05 Mar 2022 02:07:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzDEJR/yHEdFWnXc0pHQ+ViBWp74yyK9Eo9xHnLMRRGwOjXlrUAgunUqQ5UkVHlbRmy69Wo/GZFxyibXBCaP0k= X-Received: by 2002:a17:90a:dac2:b0:1bd:fecf:6bd1 with SMTP id g2-20020a17090adac200b001bdfecf6bd1mr3049372pjx.113.1646474835671; Sat, 05 Mar 2022 02:07:15 -0800 (PST) MIME-Version: 1.0 References: <20220304172852.274126-1-benjamin.tissoires@redhat.com> <20220304172852.274126-2-benjamin.tissoires@redhat.com> In-Reply-To: From: Benjamin Tissoires Date: Sat, 5 Mar 2022 11:07:04 +0100 Message-ID: Subject: Re: [PATCH bpf-next v2 01/28] bpf: add new is_sys_admin_prog_type() helper To: Song Liu Cc: Greg KH , Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Tero Kristo , open list , "open list:HID CORE LAYER" , Networking , bpf , linux-kselftest@vger.kernel.org, Sean Young Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 5, 2022 at 12:12 AM Song Liu wrote: > > On Fri, Mar 4, 2022 at 9:30 AM Benjamin Tissoires > wrote: > > > > LIRC_MODE2 does not really need net_admin capability, but only sys_admin. > > > > Extract a new helper for it, it will be also used for the HID bpf > > implementation. > > > > Cc: Sean Young > > Signed-off-by: Benjamin Tissoires > > > > --- > > > > new in v2 > > --- > > kernel/bpf/syscall.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > > index db402ebc5570..cc570891322b 100644 > > --- a/kernel/bpf/syscall.c > > +++ b/kernel/bpf/syscall.c > > @@ -2165,7 +2165,6 @@ static bool is_net_admin_prog_type(enum bpf_prog_type prog_type) > > case BPF_PROG_TYPE_LWT_SEG6LOCAL: > > case BPF_PROG_TYPE_SK_SKB: > > case BPF_PROG_TYPE_SK_MSG: > > - case BPF_PROG_TYPE_LIRC_MODE2: > > case BPF_PROG_TYPE_FLOW_DISSECTOR: > > case BPF_PROG_TYPE_CGROUP_DEVICE: > > case BPF_PROG_TYPE_CGROUP_SOCK: > > @@ -2202,6 +2201,17 @@ static bool is_perfmon_prog_type(enum bpf_prog_type prog_type) > > } > > } > > > > +static bool is_sys_admin_prog_type(enum bpf_prog_type prog_type) > > +{ > > + switch (prog_type) { > > + case BPF_PROG_TYPE_LIRC_MODE2: > > + case BPF_PROG_TYPE_EXT: /* extends any prog */ > > + return true; > > + default: > > + return false; > > + } > > +} > > I am not sure whether we should do this. This is a behavior change, that may > break some user space. Also, BPF_PROG_TYPE_EXT is checked in > is_perfmon_prog_type(), and this change will make that case useless. Sure, I can drop it from v3 and make this function appear for HID only. Regarding BPF_PROG_TYPE_EXT, it was already in both is_net_admin_prog_type() and is_perfmon_prog_type(), so I duplicated it here, but I agree, given that it's already in the first function there, CPA_SYS_ADMIN is already checked. Cheers, Benjamin > > Thanks, > Song > > [...] >