From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2F2C64E7A for ; Tue, 1 Dec 2020 18:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0168E20643 for ; Tue, 1 Dec 2020 18:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=newoldbits-com.20150623.gappssmtp.com header.i=@newoldbits-com.20150623.gappssmtp.com header.b="x6/tobbG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731270AbgLAS6y (ORCPT ); Tue, 1 Dec 2020 13:58:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730151AbgLAS6x (ORCPT ); Tue, 1 Dec 2020 13:58:53 -0500 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FF70C0613D4 for ; Tue, 1 Dec 2020 10:58:13 -0800 (PST) Received: by mail-il1-x141.google.com with SMTP id w8so2698855ilg.12 for ; Tue, 01 Dec 2020 10:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=newoldbits-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SMk7/+B37MjE2tzrVpjBEF0k4vtUEGsXD71pfxhgFE4=; b=x6/tobbGhy0Xqa4b1ZSQcuDLcGemKwX40boAQa1eiY/vGSl7jxnpqPeqR5/yS3FpPs H4Hc+PMXCJ0IGltHfd+vgWCaegFAaKywxkIEYKZe4r/+MBneGrTZOBvrsxca2KDXyvH8 JdDP0pdWBxSiGIrJ7L+xYiMM4jndSstfo4Llehjys820znyb+y7sqY++pZ2ddnJElllK g2ouCAJYkJOZTzWF1xrCPopV7Ai2smiSPHUZI+obDBekhv26x3I8U9yl5cA+/kCdRs92 Ga6uiFjckfl+uGpEzjc5xRBDxwf7XHvXSZW/bTWHimdBp2R8+iiK504op4SsxF4tJNr1 CHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SMk7/+B37MjE2tzrVpjBEF0k4vtUEGsXD71pfxhgFE4=; b=FIByzfJmdNPJ7e1e4TfgUAmkftrYqMWQvxBCXGnlqJHc0vPvS8c1UU1sf0gA68LwfW Ea4ihnMmYULNsstNx0BmpDTiguhY1MFHtQ1HzGmPRqwK10TqDQf+TT7UCeiZjYKhrjjQ jHOxPx6idLJ0+esHQnQES6IMbM4zGqE/c7f/IonFqf+7uV3IXiUpFedt7sLQsnlJEm4J UDQ4hBNpfvdxnX6dqQbeHSE0BZoIW/jLkKTbBja98kleWR2aO8QLWQFAZWam6zKdHZVB ZyHE4Yk/AjuubGqhKtnAlQfYjcXXVFyPF2KhBtbyzXrAXP/c95hQx7TxNbq136jHaBpy JUHQ== X-Gm-Message-State: AOAM533q/FzutdQ+FvM5z6rsVxzi725y7IDXnCiVw2iRcgPiNOPFRO7q G/BQli1O2PUhlIIv3sey84MCXH4FUpmRbyJ7PCAH+A== X-Google-Smtp-Source: ABdhPJyiwXnGw9orV9Hn7BmgZsCLMGAfOhVZJoqb6/qa57XsmjvhkRRffdEVO2fN4fC+AMRV9V6VaqoiuTGX8gA/hBE= X-Received: by 2002:a92:c213:: with SMTP id j19mr4050312ilo.255.1606849092404; Tue, 01 Dec 2020 10:58:12 -0800 (PST) MIME-Version: 1.0 References: <20201201083408.51006-1-jean.pihet@newoldbits.com> <20201201184100.GN2073444@lunn.ch> In-Reply-To: <20201201184100.GN2073444@lunn.ch> From: Jean Pihet Date: Tue, 1 Dec 2020 19:58:01 +0100 Message-ID: Subject: Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface To: Andrew Lunn Cc: netdev@vger.kernel.org, LKML , Ryan Barnett , Conrad Ratschan , Hugo Cornelis , Arnout Vandecappelle Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Andrew, On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > Add support for RGMII in 100 and 1000 Mbps. > > > > Adjust the CPU port settings from the host interface settings: interface > > MII type, speed, duplex. > > Hi Jean > > You have still not explained why this is needed. Why? is always the > important question to answer in the commit message. The What? is > obvious from reading the patch. Why does you board need this, when no > over board does? I reworked the commit description about the What and thought it was enough. Do you need a cover letter to describe it more? The Why is: " Configure the host port of the switch to match the host interface settings. This is useful when the switch is directly connected to the host MAC interface. " Thank you for reviewing the patch. BR, Jean > > Thanks > Andrew