From: Pooja Trivedi <poojatrivedi@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>,
Boris Pismenny <borisp@mellanox.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
John Fastabend <john.fastabend@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [net v3 0/2] net/tls: fix encryption error path
Date: Thu, 21 May 2020 12:29:22 -0400 [thread overview]
Message-ID: <CAOrEdsmuoAUD2o8mnpTyuZFGZeZyx-6pH+1Hb-T=s2d_edmPfQ@mail.gmail.com> (raw)
In-Reply-To: <20200520134655.15fead0a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, May 20, 2020 at 4:46 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 20 May 2020 11:41:42 +0300 Vadim Fedorenko wrote:
> > The problem with data stream corruption was found in KTLS
> > transmit path with small socket send buffers and large
> > amount of data. bpf_exec_tx_verdict() frees open record
> > on any type of error including EAGAIN, ENOMEM and ENOSPC
> > while callers are able to recover this transient errors.
> > Also wrong error code was returned to user space in that
> > case. This patchset fixes the problems.
>
> Thanks:
>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
>
> Pooja, I think Vadim's fix to check the socket error will make changes
> to handling of -EAGAIN unnecessary, right?
Correct, yes.
> Still would be good to get
> that selftest, triggering EAGAIN should be quite simple.
Agree.
next prev parent reply other threads:[~2020-05-21 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:41 [net v3 0/2] net/tls: fix encryption error path Vadim Fedorenko
2020-05-20 8:41 ` [net v3 1/2] net/tls: fix encryption error checking Vadim Fedorenko
2020-05-20 8:41 ` [net v3 2/2] net/tls: free record only on encryption error Vadim Fedorenko
2020-05-20 20:46 ` [net v3 0/2] net/tls: fix encryption error path Jakub Kicinski
2020-05-21 16:29 ` Pooja Trivedi [this message]
2020-05-22 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOrEdsmuoAUD2o8mnpTyuZFGZeZyx-6pH+1Hb-T=s2d_edmPfQ@mail.gmail.com' \
--to=poojatrivedi@gmail.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).