From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA59ECA9ED0 for ; Sun, 3 Nov 2019 06:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A24C0215EA for ; Sun, 3 Nov 2019 06:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727549AbfKCGsC (ORCPT ); Sun, 3 Nov 2019 01:48:02 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55355 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbfKCGsC (ORCPT ); Sun, 3 Nov 2019 01:48:02 -0500 X-Originating-IP: 209.85.217.54 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (Authenticated sender: pshelar@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C9FACE0004 for ; Sun, 3 Nov 2019 06:48:00 +0000 (UTC) Received: by mail-vs1-f54.google.com with SMTP id k1so9048330vsm.0 for ; Sat, 02 Nov 2019 23:48:00 -0700 (PDT) X-Gm-Message-State: APjAAAUJl1ddbr+DEUr4QSf5zZp3gNKMFV3h3KVIi/ACs8KawhR2BBAc PZHp9pt8sUkY46SakQ7TpJ88fMsRMYQXQTn0G/k= X-Google-Smtp-Source: APXvYqxCf6CJ+Hywsp7KjmlFO6VZUY/kCoDNp29RlUCo55VbWFwsrtVqLhiJTITmJMuBe6KXJTERusdtBCsQF8IosD0= X-Received: by 2002:a67:2804:: with SMTP id o4mr9989084vso.47.1572763679749; Sat, 02 Nov 2019 23:47:59 -0700 (PDT) MIME-Version: 1.0 References: <1572618234-6904-1-git-send-email-xiangxia.m.yue@gmail.com> <1572618234-6904-10-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1572618234-6904-10-git-send-email-xiangxia.m.yue@gmail.com> From: Pravin Shelar Date: Sat, 2 Nov 2019 23:47:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v6 09/10] net: openvswitch: don't unlock mutex when changing the user_features fails To: Tonghao Zhang Cc: Greg Rose , "David S. Miller" , Linux Kernel Network Developers , ovs dev , Paul Blakey Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > Unlocking of a not locked mutex is not allowed. > Other kernel thread may be in critical section while > we unlock it because of setting user_feature fail. > > Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") > Cc: Paul Blakey > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > Acked-by: William Tu > --- Acked-by: Pravin B Shelar