From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BD4C433F5 for ; Thu, 17 Feb 2022 14:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241053AbiBQOzB (ORCPT ); Thu, 17 Feb 2022 09:55:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242212AbiBQOzA (ORCPT ); Thu, 17 Feb 2022 09:55:00 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 795E62B2C6D for ; Thu, 17 Feb 2022 06:54:45 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id g39so10458698lfv.10 for ; Thu, 17 Feb 2022 06:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=11Msxpj6saXhCjkH+nNzBnzST2VwOlijviYdJ5EL8xY=; b=h5HMBr2qhvXOVt5Rfn/vHXtiCQDuOpsxkvtFXY0SaiScqWYvwpMJt7Ts5GoC0oM9lu oZj3IfLiiIcHvrxc3JwV25jjQsMvXlueV81dkAF15o0UJ2Wc1KHJgUiBV6+YYsPTH98G 8nWuYP3W8FBS6N4SeEuBzBAYUDcjwdH/gP8aX0MTiZXvEu4z93liPMgb34C5FYDQctPi G5G0CrnohL2XTBUHXFu9UhV0YmK4fiIERHclNELjygJMVr+BGfUBjhvEtptQCK+yxtkm aeY1WFNrw8P8mIxnuUxVsLdP4wnwmi1KwCEPf/m/0deGHDK0O/gNRAMxVaGIpLfuPW6C jOmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=11Msxpj6saXhCjkH+nNzBnzST2VwOlijviYdJ5EL8xY=; b=5sVqiAmXauOB6WU0cKPvxHOsZhqCRZU4WbTdAGSoln/p/k2qKCQAY0BmkIJNJCXpuG uc5Tzf1VHf+HULvikXT0v653F+OugVIRnwOKHDrn5rajTwl4AQu0Kjh63T/WRYfEY6bp r4up70Bvt/4YysVv45Yhk3jp451I8ZzwU6rfhKH9QMPeohOaoWZxh6QNrKFi/v7YGUbM 2PBUIKUjDnV4hcgNHSuZjdEknxQnOZURNL3vSZC/zzk72L76zeQ+PVsSw1r4zvntUN/M m5E9cSpgflrVJa8NIb4nSP3IWuRbMMgjA3yIQE8UmEz3c8pu0ruuwsHW/q2NoiYGeXeD 1AJw== X-Gm-Message-State: AOAM531zTJWKt9z6qHveKKHW20D3WhN6FpGq/YZZewDcjgF6NWoRa9lq vf5d5SnkWS96gCDUf82LpeIGgNaBcQBqk+wcaUG9Pegdm3Jb2Q== X-Google-Smtp-Source: ABdhPJxr6FXLaH1va6dG7alhD1yu9EwTbfNIoN/IWCmHeyc0IwCpkdkpbk1bdcrCPBR912vFQwi6slrPY3X5Othxofw= X-Received: by 2002:a19:9144:0:b0:43b:86a4:1497 with SMTP id y4-20020a199144000000b0043b86a41497mr2301608lfj.254.1645109683832; Thu, 17 Feb 2022 06:54:43 -0800 (PST) MIME-Version: 1.0 References: <20220216093112.92469-1-Jerome.Pouiller@silabs.com> <20220216093112.92469-3-Jerome.Pouiller@silabs.com> <878ru924qr.fsf@kernel.org> In-Reply-To: <878ru924qr.fsf@kernel.org> From: Ulf Hansson Date: Thu, 17 Feb 2022 15:54:05 +0100 Message-ID: Subject: Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200 To: Kalle Valo Cc: Jerome Pouiller , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S . Miller" , linux-mmc@vger.kernel.org, =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote: > > Jerome Pouiller writes: > > > From: J=C3=A9r=C3=B4me Pouiller > > > > Until now, the SDIO quirks are applied directly from the driver. > > However, it is better to apply the quirks before driver probing. So, > > this patch relocate the quirks in the MMC framework. > > It would be good to know how this is better, what's the concrete > advantage? The mmc core has a quirk interface for all types of cards (eMMC/SD/SDIO), which thus keeps these things from sprinkling to drivers. In some cases, the quirk needs to be applied already during card initialization, which is earlier than when probing an SDIO func driver or the MMC block device driver. Perhaps it's a good idea to explain a bit about this in the commit message. Kind regards Uffe