From: Peter Oskolkov <posk@google.com>
To: David Ahern <dsahern@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>, Peter Oskolkov <posk@posk.io>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH bpf-next v10 5/7] bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c
Date: Wed, 13 Feb 2019 12:41:13 -0800 [thread overview]
Message-ID: <CAPNVh5fkQv1Ov6fmgrakmT-X3qU-FYPsCTii7ONWW3AVe9ppbA@mail.gmail.com> (raw)
In-Reply-To: <80849fb5-c5de-ce6b-6c25-bd152326196c@gmail.com>
On Wed, Feb 13, 2019 at 12:11 PM David Ahern <dsahern@gmail.com> wrote:
>
> On 2/13/19 12:57 PM, Peter Oskolkov wrote:
> > Thanks, David! I was not able to reproduce the leak, but based on your
> > suggestion and similar code elsewhere I made a change in v11 to explicitly
> > release a dst with error.
>
> ok. Did you run the test with a debug kernel - checking refcount, use
> after free, etc?
In my tests I was always getting ERR_PTR for unroutable packets,
not a full rt/dst with an error flag set. But I checked several
similar route lookups,
and they all release bad dsts, so I did not feel it was worth it to
investigate further.
next prev parent reply other threads:[~2019-02-13 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 17:32 [PATCH bpf-next v10 0/7] bpf: add BPF_LWT_ENCAP_IP option to bpf_lwt_push_encap Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 1/7] bpf: add plumbing for BPF_LWT_ENCAP_IP in bpf_lwt_push_encap Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 2/7] bpf: implement BPF_LWT_ENCAP_IP mode " Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 3/7] bpf: handle GSO " Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 4/7] ipv6_stub: add ipv6_route_input stub/proxy Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 5/7] bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c Peter Oskolkov
2019-02-13 2:58 ` David Ahern
2019-02-13 19:57 ` Peter Oskolkov
2019-02-13 20:11 ` David Ahern
2019-02-13 20:41 ` Peter Oskolkov [this message]
2019-02-12 17:32 ` [PATCH bpf-next v10 6/7] bpf: sync <kdir>/include/.../bpf.h with tools/include/.../bpf.h Peter Oskolkov
2019-02-12 17:32 ` [PATCH bpf-next v10 7/7] selftests: bpf: add test_lwt_ip_encap selftest Peter Oskolkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPNVh5fkQv1Ov6fmgrakmT-X3qU-FYPsCTii7ONWW3AVe9ppbA@mail.gmail.com \
--to=posk@google.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=posk@posk.io \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).