From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BD1C48BD5 for ; Wed, 26 Jun 2019 01:35:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B70A20883 for ; Wed, 26 Jun 2019 01:35:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7uUPnY0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbfFZBfs (ORCPT ); Tue, 25 Jun 2019 21:35:48 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46949 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726750AbfFZBfq (ORCPT ); Tue, 25 Jun 2019 21:35:46 -0400 Received: by mail-qt1-f195.google.com with SMTP id h21so610257qtn.13; Tue, 25 Jun 2019 18:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0jOVApdbcnmQ0gZ+s+iXjEnjmT2qng2C8MAWEXFhcLM=; b=D7uUPnY0JIqehepH86/rg5CV9NOaQrvG3BqpmFHjf6mMuP2rRQze8DKufn7mYx2ZAd wge+/l/A5dnUhkrbqswIWIKk9CZYofTFZyaj/lqvV85J1lLDAYfqxABlTKKNsvoByXUB O4YRz6320HaOIaW6pBhHr+1/5OXnwdhKNBZjaDckxbWoOyHvkDEm6LULYvGrUAZ4qFKf KatbGZKx/hCWWIwWTqi+krbMaf35cgwm5GRGkiCNhb1RhGFTChgut31GbwPL2HEkCwhY Q0GIhvzU2TSSLq4QtYhBFb+CLcL3jcSBsjJNVEXLXhR4onWZ05glVZig+X5uSc7RYV4E WTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0jOVApdbcnmQ0gZ+s+iXjEnjmT2qng2C8MAWEXFhcLM=; b=q8oUS2tg2vGqTtNw4cbJTkUykSSIMj/hzvFwtWyFCyObS46OOTqUUTh5OuupK8QoZ/ jOi17I1LZLnss+L+fVTAtcVXE+la0PdecpkzKl8eyZgrI8TQtEVGKapRVDG+7jIDAz42 MUhOvY+fdMev8oIxcDvu5YtyBSM1/FIvMW8gyu93AE4P0oxZ11yjD+WsUkKMOkIAaPX+ gm6IGGiocnlzXbQOh6CLscpxM0wEWja/qejgH3qdzV3PL7YGVtzQcD4/xDCpj8ni9ucE qQrAlRttZ/nFeRz4/TdmMsGYjHW4YqJxqIMPO/HPqH64yFawHnC9ZkvMKbcNacXoV6fx oV0Q== X-Gm-Message-State: APjAAAUYloPckoW6EG/XO1U7cTAaOfiFHo/UXl22uI8gi0BY8e+hwp5B Wg2UQxhfe8IlBbSYCrBAZPC4JjnK66YITu+V/Yk= X-Google-Smtp-Source: APXvYqzqQn3I+yuRy5UB66EDdkdlfdfXf+20eBNYN25S+bi1B5Ul4jyWQQqbEzJdDwwbejiFylmwtSgBMbjvcAd6eKs= X-Received: by 2002:aed:38c2:: with SMTP id k60mr1262888qte.83.1561512945624; Tue, 25 Jun 2019 18:35:45 -0700 (PDT) MIME-Version: 1.0 References: <20190626003852.163986-1-allanzhang@google.com> In-Reply-To: <20190626003852.163986-1-allanzhang@google.com> From: Song Liu Date: Tue, 25 Jun 2019 18:35:34 -0700 Message-ID: Subject: Re: [PATCH bpf-next v6 0/2] bpf: Allow bpf_skb_event_output for more prog types To: allanzhang Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , Networking , bpf , open list Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 25, 2019 at 5:39 PM allanzhang wrote: > > Software event output is only enabled by a few prog types right now (TC, > LWT out, XDP, sockops). Many other skb based prog types need > bpf_skb_event_output to produce software event. > > More prog types are enabled to access bpf_skb_event_output in this > patch. > > v2 changes: > Reformating log message. > > v3 changes: > Reformating log message. > > v4 changes: > Reformating log message. > > v5 changes: > Fix typos, reformat comments in event_output.c, move revision history to > cover letter. > > v6 changes: > fix Signed-off-by, fix fixup map creation. > > allanzhang (2): I guess you manually fixed the name in the other two patches, but forgot this one. You can fix it in your .gitconfig file. Make sure to get the proper capital letters. Also, please run ./scripts/checkpatch.pl on your patch files. This will help you find a lot of issues. Thanks, Song > bpf: Allow bpf_skb_event_output for a few prog types > bpf: Add selftests for bpf_perf_event_output > > net/core/filter.c | 6 ++ > tools/testing/selftests/bpf/test_verifier.c | 12 ++- > .../selftests/bpf/verifier/event_output.c | 94 +++++++++++++++++++ > 3 files changed, 111 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/verifier/event_output.c > > -- > 2.22.0.410.gd8fdbe21b5-goog >