Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Stefan Chulski <stefanc@marvell.com>
Cc: netdev <netdev@vger.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	nadavh@marvell.com, Yan Markman <ymarkman@marvell.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	atenart@kernel.org
Subject: Re: [net-next] net: mvpp2: skip RSS configurations on loopback port
Date: Thu, 18 Feb 2021 16:08:05 +0100
Message-ID: <CAPv3WKfsmJuV909D+os3ukH5F3X1oRPQrjD6y_t7R7U-AONxFw@mail.gmail.com> (raw)
In-Reply-To: <1613652123-19021-1-git-send-email-stefanc@marvell.com>

Hi,


czw., 18 lut 2021 o 13:42 <stefanc@marvell.com> napisał(a):
>
> From: Stefan Chulski <stefanc@marvell.com>
>
> PPv2 loopback port doesn't support RSS, so we should
> skip RSS configurations for this port.
>
> Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 25 +++++++++++---------
>  1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 10c17d1..d415447 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4699,9 +4699,10 @@ static void mvpp2_irqs_deinit(struct mvpp2_port *port)
>         }
>  }
>
> -static bool mvpp22_rss_is_supported(void)
> +static bool mvpp22_rss_is_supported(struct mvpp2_port *port)
>  {
> -       return queue_mode == MVPP2_QDIST_MULTI_MODE;
> +       return (queue_mode == MVPP2_QDIST_MULTI_MODE) &&
> +               !(port->flags & MVPP2_F_LOOPBACK);
>  }
>
>  static int mvpp2_open(struct net_device *dev)
> @@ -5513,7 +5514,7 @@ static int mvpp2_ethtool_get_rxnfc(struct net_device *dev,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret = 0, i, loc = 0;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>
>         switch (info->cmd) {
> @@ -5548,7 +5549,7 @@ static int mvpp2_ethtool_set_rxnfc(struct net_device *dev,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret = 0;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>
>         switch (info->cmd) {
> @@ -5569,7 +5570,9 @@ static int mvpp2_ethtool_set_rxnfc(struct net_device *dev,
>
>  static u32 mvpp2_ethtool_get_rxfh_indir_size(struct net_device *dev)
>  {
> -       return mvpp22_rss_is_supported() ? MVPP22_RSS_TABLE_ENTRIES : 0;
> +       struct mvpp2_port *port = netdev_priv(dev);
> +
> +       return mvpp22_rss_is_supported(port) ? MVPP22_RSS_TABLE_ENTRIES : 0;
>  }
>
>  static int mvpp2_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key,
> @@ -5578,7 +5581,7 @@ static int mvpp2_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret = 0;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>
>         if (indir)
> @@ -5596,7 +5599,7 @@ static int mvpp2_ethtool_set_rxfh(struct net_device *dev, const u32 *indir,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret = 0;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>
>         if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_CRC32)
> @@ -5617,7 +5620,7 @@ static int mvpp2_ethtool_get_rxfh_context(struct net_device *dev, u32 *indir,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret = 0;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>         if (rss_context >= MVPP22_N_RSS_TABLES)
>                 return -EINVAL;
> @@ -5639,7 +5642,7 @@ static int mvpp2_ethtool_set_rxfh_context(struct net_device *dev,
>         struct mvpp2_port *port = netdev_priv(dev);
>         int ret;
>
> -       if (!mvpp22_rss_is_supported())
> +       if (!mvpp22_rss_is_supported(port))
>                 return -EOPNOTSUPP;
>
>         if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_CRC32)
> @@ -5956,7 +5959,7 @@ static int mvpp2_port_init(struct mvpp2_port *port)
>         mvpp2_cls_oversize_rxq_set(port);
>         mvpp2_cls_port_config(port);
>
> -       if (mvpp22_rss_is_supported())
> +       if (mvpp22_rss_is_supported(port))
>                 mvpp22_port_rss_init(port);
>
>         /* Provide an initial Rx packet size */
> @@ -6861,7 +6864,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
>         dev->hw_features |= features | NETIF_F_RXCSUM | NETIF_F_GRO |
>                             NETIF_F_HW_VLAN_CTAG_FILTER;
>
> -       if (mvpp22_rss_is_supported()) {
> +       if (mvpp22_rss_is_supported(port)) {
>                 dev->hw_features |= NETIF_F_RXHASH;
>                 dev->features |= NETIF_F_NTUPLE;
>         }
> --
> 1.9.1
>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Thanks!

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 12:42 stefanc
2021-02-18 15:08 ` Marcin Wojtas [this message]
2021-02-23  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPv3WKfsmJuV909D+os3ukH5F3X1oRPQrjD6y_t7R7U-AONxFw@mail.gmail.com \
    --to=mw@semihalf.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git