netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Chulski <stefanc@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Nadav Haklai <nadavh@marvell.com>,
	Yan Markman <ymarkman@marvell.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
	"atenart@kernel.org" <atenart@kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map
Date: Mon, 25 Jan 2021 07:16:48 +0000	[thread overview]
Message-ID: <CO6PR18MB3873091FEF05CDB3B22B1162B0BD9@CO6PR18MB3873.namprd18.prod.outlook.com> (raw)
In-Reply-To: <YA3Afgtq0thFDH6Z@lunn.ch>

> >  #include <linux/of_net.h>
> >  #include <linux/of_address.h>
> >  #include <linux/of_device.h>
> > +#include <linux/genalloc.h>
> >  #include <linux/phy.h>
> >  #include <linux/phylink.h>
> >  #include <linux/phy/phy.h>
> > @@ -91,6 +92,18 @@ static inline u32 mvpp2_cpu_to_thread(struct
> mvpp2 *priv, int cpu)
> >  	return cpu % priv->nthreads;
> >  }
> >
> > +static inline
> > +void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data) {
> > +	writel(data, priv->cm3_base + offset); }
> > +
> > +static inline
> > +u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset) {
> > +	return readl(priv->cm3_base + offset); }
> 
> No inline functions in .c file please. Let the compiler decide.
> 
>    Andrew

Ok, I would fix.

Thanks,
Stefan.

  reply	other threads:[~2021-01-25  8:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24 11:43 [PATCH v2 RFC net-next 00/18] net: mvpp2: Add TX Flow Control support stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 01/18] doc: marvell: add cm3-mem device tree bindings description stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 02/18] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map stefanc
2021-01-24 12:28   ` Russell King - ARM Linux admin
2021-01-24 12:44   ` Russell King - ARM Linux admin
2021-01-24 18:51     ` Andrew Lunn
2021-01-24 18:46   ` Andrew Lunn
2021-01-25  7:16     ` Stefan Chulski [this message]
2021-01-24 11:43 ` [PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition stefanc
2021-01-24 13:18   ` Russell King - ARM Linux admin
2021-01-24 13:55     ` [EXT] " Stefan Chulski
2021-01-24 19:03       ` Andrew Lunn
2021-01-25  7:12         ` Stefan Chulski
2021-01-24 11:43 ` [PATCH v2 RFC net-next 05/18] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 06/18] net: mvpp2: increase BM pool size to 2048 buffers stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 07/18] net: mvpp2: increase RXQ size to 1024 descriptors stefanc
2021-01-24 11:43 ` [PATCH v2 RFC net-next 08/18] net: mvpp2: add FCA periodic timer configurations stefanc
2021-01-24 12:14   ` Russell King - ARM Linux admin
2021-01-24 14:43     ` [EXT] " Stefan Chulski
2021-01-24 19:11       ` Andrew Lunn
2021-01-25  7:15         ` Stefan Chulski
2021-01-24 11:43 ` [PATCH v2 RFC net-next 09/18] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-01-24 13:01   ` Russell King - ARM Linux admin
2021-01-24 13:24     ` [EXT] " Stefan Chulski
2021-01-24 11:43 ` [PATCH v2 RFC net-next 10/18] net: mvpp2: add spinlock for FW FCA configuration path stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 11/18] net: mvpp2: enable global flow control stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 12/18] net: mvpp2: add RXQ flow control configurations stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 13/18] net: mvpp2: add ethtool flow control configuration support stefanc
2021-01-24 12:35   ` Russell King - ARM Linux admin
2021-01-24 12:39     ` [EXT] " Stefan Chulski
2021-01-24 11:44 ` [PATCH v2 RFC net-next 14/18] net: mvpp2: add BM protection underrun feature support stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 15/18] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 16/18] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 17/18] net: mvpp2: limit minimum ring size to 1024 descriptors stefanc
2021-01-24 11:44 ` [PATCH v2 RFC net-next 18/18] net: mvpp2: add TX FC firmware check stefanc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB3873091FEF05CDB3B22B1162B0BD9@CO6PR18MB3873.namprd18.prod.outlook.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).