From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66A8C04AB5 for ; Mon, 3 Jun 2019 18:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F29227407 for ; Mon, 3 Jun 2019 18:26:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oyYL7ar+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbfFCS0E (ORCPT ); Mon, 3 Jun 2019 14:26:04 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44936 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfFCS0E (ORCPT ); Mon, 3 Jun 2019 14:26:04 -0400 Received: by mail-pg1-f195.google.com with SMTP id n2so8744403pgp.11 for ; Mon, 03 Jun 2019 11:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=4k7GRXlyfxsLxv0xefE/UVRhHlrS8tnLjxoE+uikhqA=; b=oyYL7ar+UzLKxFjX3zxaKvu8PIl4t73wueYt64ond6gChuCw2cH7euWYZNkPjATGOH xTcZFwTcCr3ZhbBwYTPvrn5+y+7VgNFFINphebnPT4Vsb6JvbVKyTpeasgPE1ReMOUwB zViM16RWi8VXDLjEE8FZngbYIG7LNZymny/gbDmkq24EutSD5BZKfNpfjaIqOAdldd4Q P0FsmxdOCc6kBHYxV0YX56SldPBpVfok31i6WQxPsWOMd6Q9LYmdyqAKY7UhgseypIjV XwuFmEuuJETjncemnaZxPAFA2P/ebkbPKmUzi1+3P3jlhJP2wvBMqKXsu3h1WlY3b+Hz R+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=4k7GRXlyfxsLxv0xefE/UVRhHlrS8tnLjxoE+uikhqA=; b=VEWNplfx7JI/PdZCT9mbClk73o/HZ/vVBCbC5YKkFvSipD7BVnbqfKbTF0ruYtmIHs DzBFdNkzOfLkm5YBZuR2qeZWG7Pj7pM4L+46XeTuLC9+qMTzYRsvx0DA7PVZk2Wm/CrR tlkp5itoxC6OcWXlCygBArSaysLbx94MJuJKeO9UoBgbe8Dx5UNwftV+0dHwdRSSTL/B GmlfGrmS4kIjbNtE5RXUeA+ccQhKwHWkt7Jur9psWE50oM1hHVuqDveCPcoxjHrx3jLh T1b45rCa/d3iU6pNv5uj1GNsdQ3pWlpAAlGf922jxTvljWWt+ZlFaOvGesFtXhRbs0zm xF5w== X-Gm-Message-State: APjAAAW+SkU18GR5fXflI+MfE3a9y9Aw7BqsDf2dQ0F4nNMmEnZjAuKS qP37rKgBDHIxRCskb5wxdlE= X-Google-Smtp-Source: APXvYqyQILvIjkQ5y/4e9ZnPj1Bzk/nMLurInMv2WGl/Y6NamhkeDUXD6jJWGKqZTwZxpkJS0fBOXA== X-Received: by 2002:a62:bd0e:: with SMTP id a14mr33153261pff.44.1559586363580; Mon, 03 Jun 2019 11:26:03 -0700 (PDT) Received: from [172.20.92.49] ([2620:10d:c090:180::96c4]) by smtp.gmail.com with ESMTPSA id g17sm25295204pfk.55.2019.06.03.11.26.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 11:26:02 -0700 (PDT) From: "Jonathan Lemon" To: "Maciej Fijalkowski" Cc: magnus.karlsson@intel.com, bjorn.topel@intel.com, netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, songliubraving@fb.com Subject: Re: [RFC PATCH bpf-next 4/4] libbpf: don't remove eBPF resources when other xsks are present Date: Mon, 03 Jun 2019 11:26:01 -0700 X-Mailer: MailMate (1.12.5r5635) Message-ID: In-Reply-To: <20190603131907.13395-5-maciej.fijalkowski@intel.com> References: <20190603131907.13395-1-maciej.fijalkowski@intel.com> <20190603131907.13395-5-maciej.fijalkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3 Jun 2019, at 6:19, Maciej Fijalkowski wrote: > In case where multiple xsk sockets are attached to a single interface > and one of them gets detached, the eBPF maps and program are removed. > This should not happen as the rest of xsksocks are still using these > resources. I'm not seeing that behavior - each xsk holds it's own reference to xsks_maps, so when the map descriptor is closed, it doesn't necessarily delete the map. There's no refcount on the bpf program though; so the socket should not be trying to remove the program - that should be done by the application. -- Jonathan