From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B47C43381 for ; Tue, 26 Feb 2019 15:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF398217F5 for ; Tue, 26 Feb 2019 15:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="E8VX4NBm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbfBZPBV (ORCPT ); Tue, 26 Feb 2019 10:01:21 -0500 Received: from mail-eopbgr70051.outbound.protection.outlook.com ([40.107.7.51]:27008 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726151AbfBZPBV (ORCPT ); Tue, 26 Feb 2019 10:01:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GanR24pEzvWN2Ae42utosbHT5ysqsRjh+BzpfYc6FXE=; b=E8VX4NBmKjhET6nTllHOFfNqv+PRBjyuFH1/k52oZlVN8YljGMzhHjcRlfemrgjEePfYVxptbsMU4aupfxv0u+Zt5EAMsskSghMiSxlnLpuixV78zWaZKvMnR13an1kcu8zu1Z/RAEAw5nww6oXJzSQ+DBq3uzcYc+xgUmAy1hE= Received: from DB7PR04MB4252.eurprd04.prod.outlook.com (52.135.131.26) by DB7PR04MB4154.eurprd04.prod.outlook.com (52.135.130.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.18; Tue, 26 Feb 2019 15:01:17 +0000 Received: from DB7PR04MB4252.eurprd04.prod.outlook.com ([fe80::9ca:d78:c154:25b5]) by DB7PR04MB4252.eurprd04.prod.outlook.com ([fe80::9ca:d78:c154:25b5%4]) with mapi id 15.20.1643.019; Tue, 26 Feb 2019 15:01:17 +0000 From: Vakul Garg To: Boris Pismenny , "aviadye@mellanox.com" , "davejwatson@fb.com" , "john.fastabend@gmail.com" , "daniel@iogearbox.net" , "netdev@vger.kernel.org" CC: "eranbe@mellanox.com" Subject: RE: [PATCH net 4/4] tls: Fix tls_device receive Thread-Topic: [PATCH net 4/4] tls: Fix tls_device receive Thread-Index: AQHUzcyd6ACP6pLKjUaChKE5wGmzdKXyK9vA Date: Tue, 26 Feb 2019 15:01:17 +0000 Message-ID: References: <20190226121235.20784-1-borisp@mellanox.com> <20190226121235.20784-5-borisp@mellanox.com> In-Reply-To: <20190226121235.20784-5-borisp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vakul.garg@nxp.com; x-originating-ip: [160.202.37.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d13abe33-9463-4fa9-02b7-08d69bfb426f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB7PR04MB4154; x-ms-traffictypediagnostic: DB7PR04MB4154: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1;DB7PR04MB4154;23:lw+4ZBtYIWFZAGbMjRe3y0T9Cwts6AOY/Wo1RbBy/?= =?us-ascii?Q?97lEiO2tTQCCSnc43vvRajV1DtqqJGeT943fO6O5QEt3cxvL9ogzJuC0zzue?= =?us-ascii?Q?URUgEoSAoxcpX2vs1hkdoL+X2IBLfFJLFdD9+rP2YwQ6xbUBsoe4+uPhvMwl?= =?us-ascii?Q?qzwVahuvmL5KkgxEpoenycZ4dxzmKMHB6tNZPyUbVnKb9UwY7RImBR1+cqCS?= =?us-ascii?Q?4xcPNrrT2WKouN4p+gWZZKEAB0rXTgpduAFa9g50A/TLIkozbDv//OjJ8qJr?= =?us-ascii?Q?mAwL7NzlOgA7Bt2w5m6f36oUps+mFxOlefJEEE8Mz2AxtSgU9AV/e4xkaOuw?= =?us-ascii?Q?nzzgvwIHWyQvNmD2/hFZ+NdGlC7wkXM8ZU0fERMw7HFwig7c6DcEChUxImiE?= =?us-ascii?Q?sf5clPaMNdYhf3Q9dRoikcuT3oJxeluooD5KySICZYwWaI122tDlGC8QOJLo?= =?us-ascii?Q?RZmLyECN5y388mto2FYLpcZev4FBxouKfrxxLdCP302rmxzzIWf38LRUteen?= =?us-ascii?Q?/7H17/lOKvfR5QiJJBGpQMewj/x4WXFpU9Er3G7UZteRPz0qs/FnV2P7zGMC?= =?us-ascii?Q?rQ68uPtmNhZdA3I0TAnX0jwsma1axOOkeZELXYZ26g4r2ql63wpmmoZpQeHf?= =?us-ascii?Q?ia33FTzkNZMhAqZL/v7JTJN6HrUHjwnbw0oZC2NDgd13wJK+GKdyrY3Q4qGI?= =?us-ascii?Q?Wkpg+aIQuMG9cDfVGGOQbfArabq4MeN9Xaut+5tKptcMyMfKXRd37inrhfxv?= =?us-ascii?Q?pdICm9DQNtU5CrHIFz5VnKaiLCD7Y77R07ZnfY1N9+FxLq14g6tnlXTE9FN1?= =?us-ascii?Q?vy5aqYaHkcwZrDwkka6YSr7Sf8DnS8c/1Kj2BxdHGxTD1k8f6GZcZGB2nenB?= =?us-ascii?Q?2+mvpOM21Edu8Shh6NxrLpGkINtApd39dM7pHC3q9ZMpFk4seqq2wJkQ1MiK?= =?us-ascii?Q?y9ACuAukWWO2qxrNEJuid9iOfHHR26gTbkOhJGF/5hkUmbVahX/OI44WZYr5?= =?us-ascii?Q?RKrC0CVC3RPElQ4SwZtaQtI+TSCz3M6P3CRD/b9scOWlzTYuD18iFp/8bCXh?= =?us-ascii?Q?ubDs+o2yxHyzzppUJ7N9/BQK6pRVrVk8t/rMRFEMmHJROPmHqnjXxFEB9ZAH?= =?us-ascii?Q?hHfk1KBTexYA6CDVeBw46+pyesVh9ES7S0STiXqZ7Oyug7Bn/F9AICBjzXIt?= =?us-ascii?Q?dYEvnIvQ8PsUonRTjaaiekQMEyTnqx0KvDqeuqhckaduoM5dS9zEe6pYkWvw?= =?us-ascii?Q?Voyw9lfbW3ekFXd+LZavJELMyQIE00x+v9AIOyIaGGuJyx+54ChkFHhIjmBH?= =?us-ascii?Q?Lf31Cq5UCM/iXN/2/pon70=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 096029FF66 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(366004)(346002)(376002)(396003)(199004)(189003)(13464003)(6246003)(14454004)(97736004)(11346002)(446003)(476003)(2501003)(486006)(2201001)(4326008)(86362001)(81156014)(8936002)(33656002)(3846002)(25786009)(8676002)(6116002)(81166006)(44832011)(68736007)(99286004)(110136005)(105586002)(106356001)(66066001)(6506007)(316002)(6436002)(9686003)(55016002)(74316002)(478600001)(2906002)(305945005)(7736002)(229853002)(7696005)(26005)(186003)(102836004)(53546011)(53936002)(71190400001)(71200400001)(52536013)(14444005)(256004)(5660300002)(76176011);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR04MB4154;H:DB7PR04MB4252.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: I7V2XOmX4LBPCYH+58ferzP0iiRu61NnqqxSn03RVWGqkkcyroMSj1+mNvvqVw2fkuIMZG8C2GBGSfGyI77E6zUmukr49wTB5YCfzAlO2jOvxvObQ8m6YhILU89FcmNBrn4xQ4iBcCGSs236PveSjdyix8w86/Xj6CmSm1W/jcHgdxP+6owfN5DEkfXLspm76+f+hIdTHAJJc7oxHhMCOcyu0h5zkjNOESsB6r+235BR8OBm6u338f/MQMjyBTNy6ogpkD4d13utnunWLQTVxo2woqGGXm5J0lFVgczf9zHM7oMiCm/2P+0TUmJebtBuEOaWm0q/AHnejpZ2L3u2lEWDZ6m8U27pwh7ERjxBeGgzzmL/pzx5HSqEewWTs9LRTzwYtTXW5ZbOCnBCkXeJLfFEwEbLLZBQfF5URf1/uiI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d13abe33-9463-4fa9-02b7-08d69bfb426f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2019 15:01:17.2871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4154 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Boris Pismenny > Sent: Tuesday, February 26, 2019 5:43 PM > To: aviadye@mellanox.com; davejwatson@fb.com; > john.fastabend@gmail.com; daniel@iogearbox.net; Vakul Garg > ; netdev@vger.kernel.org > Cc: eranbe@mellanox.com; borisp@mellanox.com > Subject: [PATCH net 4/4] tls: Fix tls_device receive >=20 > Currently, the receive function fails to handle records already decrypted= by > the device due to the commit mentioned below. >=20 > This commit advances the TLS record sequence number and prepares the > context to handle the next record. >=20 > Fixes: fedf201e1296 ("net: tls: Refactor control message handling on recv= ") > Signed-off-by: Boris Pismenny > Reviewed-by: Eran Ben Elisha > --- > net/tls/tls_sw.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) >=20 > diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index > f515cd7e984e..85da10182d8d 100644 > --- a/net/tls/tls_sw.c > +++ b/net/tls/tls_sw.c > @@ -1481,18 +1481,17 @@ static int decrypt_skb_update(struct sock *sk, > struct sk_buff *skb, >=20 > return err; > } > - > - rxm->full_len -=3D padding_length(ctx, tls_ctx, skb); > - > - rxm->offset +=3D prot->prepend_size; > - rxm->full_len -=3D prot->overhead_size; > - tls_advance_record_sn(sk, &tls_ctx->rx, version); > - ctx->decrypted =3D true; > - ctx->saved_data_ready(sk); > } else { > *zc =3D false; > } >=20 > + rxm->full_len -=3D padding_length(ctx, tls_ctx, skb); > + rxm->offset +=3D prot->prepend_size; > + rxm->full_len -=3D prot->overhead_size; > + tls_advance_record_sn(sk, &tls_ctx->rx, version); > + ctx->decrypted =3D true; > + ctx->saved_data_ready(sk); > + > return err; > } >=20 > -- > 2.12.2 Reviewed-by: Vakul Garg =20