netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
	"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
	"joabreu@synopsys.com" <joabreu@synopsys.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back
Date: Tue, 23 Feb 2021 07:16:52 +0000	[thread overview]
Message-ID: <DB8PR04MB679598EB6F86026DAB6FCE16E6809@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210222114737.740469eb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 2021年2月23日 3:48
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com;
> joabreu@synopsys.com; davem@davemloft.net; netdev@vger.kernel.org;
> dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac
> resume back
> 
> On Sat, 20 Feb 2021 07:52:46 +0000 Joakim Zhang wrote:
> > > I'm not sure why you recycle and reallocate every buffer. Isn't it
> > > enough to reinitialize the descriptors with the buffers which are already
> allocated?
> >
> > As I know, the receive buffer address is not fixed after allocated, it
> > will recycle and re-allocate in stmmac_rx(), where to handle the
> > receive buffers.
> 
> Not sure what you mean by that. The driver must know the addresses of the
> memory it allocated and handed over to the device.

What I mean is that, in stmmac driver, it creates a page pool for rx patch, it will always recycle and re-allocate pages to fill descriptors' dma address.

Best Regards,
Joakim Zhang
> > It should be enough to re-initialize the descriptors with the buffers
> > if it is possible. Could you point me how to do it?


      reply	other threads:[~2021-02-23  7:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:21 [PATCH V4 net 0/5] ethernet: fixes for stmmac driver Joakim Zhang
2021-02-04 11:21 ` [PATCH V4 net 1/5] net: stmmac: stop each tx channel independently Joakim Zhang
2021-02-04 11:21 ` [PATCH V4 net 2/5] net: stmmac: fix watchdog timeout during suspend/resume stress test Joakim Zhang
2021-02-04 11:21 ` [PATCH V4 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring Joakim Zhang
2021-02-06 20:29   ` Jakub Kicinski
2021-02-20  7:43     ` Joakim Zhang
2021-02-22 19:46       ` Jakub Kicinski
2021-02-23  7:10         ` Joakim Zhang
2021-02-04 11:21 ` [PATCH V4 net 4/5] net: stmmac: fix wrongly set buffer2 valid when sph unsupport Joakim Zhang
2021-02-04 11:21 ` [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back Joakim Zhang
2021-02-06 20:38   ` Jakub Kicinski
2021-02-20  7:52     ` Joakim Zhang
2021-02-22 19:47       ` Jakub Kicinski
2021-02-23  7:16         ` Joakim Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB679598EB6F86026DAB6FCE16E6809@DB8PR04MB6795.eurprd04.prod.outlook.com \
    --to=qiangqing.zhang@nxp.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).