From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver
Date: Wed, 24 Feb 2021 01:46:28 +0000 [thread overview]
Message-ID: <DB8PR04MB6795B3804780DB7EF0BDFF5DE69F9@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210223084602.0d1aba9d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 2021年2月24日 0:46
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com;
> joabreu@synopsys.com; davem@davemloft.net; netdev@vger.kernel.org;
> dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for
> gmac driver
>
> On Tue, 23 Feb 2021 18:48:16 +0800 Joakim Zhang wrote:
> > +static int stmmac_bus_clks_enable(struct stmmac_priv *priv, bool
> > +enabled)
>
> nit: my personal preference is to not call functions .._enable() and then make
> them have a parameter saying if it's enable or disable.
> Call the function .._config() or .._set() or such.
OK, thanks, will improve it.
Best Regards,
Joakim Zhang
next prev parent reply other threads:[~2021-02-24 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 10:48 [PATCH V1 net-next 0/3] net: stmmac: implement clocks Joakim Zhang
2021-02-23 10:48 ` [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver Joakim Zhang
2021-02-23 16:46 ` Jakub Kicinski
2021-02-24 1:46 ` Joakim Zhang [this message]
2021-02-23 10:48 ` [PATCH V1 net-next 2/3] net: stmmac: add platform level clocks management Joakim Zhang
2021-02-23 10:48 ` [PATCH V1 net-next 3/3] net: stmmac: add platform level clocks management for i.MX Joakim Zhang
2021-02-23 16:45 ` [PATCH V1 net-next 0/3] net: stmmac: implement clocks Jakub Kicinski
2021-02-24 1:45 ` Joakim Zhang
2021-02-24 1:54 ` Jakub Kicinski
2021-02-24 2:13 ` Joakim Zhang
2021-02-24 2:34 ` Jakub Kicinski
2021-02-24 2:47 ` Joakim Zhang
2021-02-24 3:54 ` Florian Fainelli
2021-02-25 1:42 ` Joakim Zhang
2021-02-24 9:03 ` Joakim Zhang
2021-02-24 13:01 ` Andrew Lunn
2021-02-25 2:15 ` Joakim Zhang
[not found] ` <DB8PR04MB6795FAE4C1736AABDCA75FA7E69E9@DB8PR04MB6795.eurprd04.prod.outlook.com>
2021-02-25 2:33 ` Andrew Lunn
2021-02-25 11:48 ` Joakim Zhang
2021-02-25 13:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB6795B3804780DB7EF0BDFF5DE69F9@DB8PR04MB6795.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).