From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17C3C3A5A2 for ; Fri, 23 Aug 2019 14:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B92922173E for ; Fri, 23 Aug 2019 14:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QE2pl+nQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395204AbfHWOYh (ORCPT ); Fri, 23 Aug 2019 10:24:37 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35281 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732212AbfHWOYg (ORCPT ); Fri, 23 Aug 2019 10:24:36 -0400 Received: by mail-pl1-f194.google.com with SMTP id gn20so5676996plb.2 for ; Fri, 23 Aug 2019 07:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=Dx4OxjkwIl1OkvlS3GG0aUCR5vpj/3I3WD3unWVJozI=; b=QE2pl+nQhBqrVeM8gAu7UeSEDnTI1NwB9swwrM3nSJHFgiUGpritQ2NCXSHU97Vbvf grbZ1kpEHw+WeFf+O1FuAaCtgR/mmm/lhMHvrai5+eQTuh1KgZQReqTg2goHUncXGaiE 7gh+nZ3GGB08/szj3oWascc1gC+dLx21yaTmrWLmLFS8m/uA4i9ILKb5+y41vE35fRZb dklPPj015dIdp1mO02vUD8VaeHL8NZYTDAVnUmi1AgDmqB8rLhOBrE6UH0wfEf3zwWHf DYDu5UTh7X1PzpJECyWIbRqkZQlQNoYO8RQNufKByXjpPUXwvmksKhsgYDBKwJM9iZgt N86A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=Dx4OxjkwIl1OkvlS3GG0aUCR5vpj/3I3WD3unWVJozI=; b=VOPYNn8EruV9u8IUh1iVxoLNdv2js5oEYoEH8/sbADcjAcMz5SVpgudEUmfiTjFPmd xPGydGqxOppbfubZI0mAcx2qRrSdNfH1O8KlYxAP+zFS469KDJJ+MojXITXmDa0QUGQF 8ERhtDDJkCzmi46k8zHDmEYesgzw/hdUPIx0K+d5NOKlRMxfO8mAG5kA9gZplSi/tz51 IpNRWbcHYVCfWmP18jJGJBTIlE3kBOXUCuWIqWZ+B9ix4gr3+WmWxrLk8fJe+pdaMVvd 84kUAQMJHWmdFCL+gituNA8nUKUEbreNRYXa2AzaDVg/z/CN9pOvF5gzgDFO4iTgh6ia spWQ== X-Gm-Message-State: APjAAAUP41W2hG/dSTwJfmnkO03jrvrQPMMdLoqkoZ2cQPlBuCdChG/O EYSMAJqRpZawOz7fnvWAqx12UN0V X-Google-Smtp-Source: APXvYqwVRGfIYj2QMndJPNGqUKhMvQvLKeld3KsFnY8LZZ91bk++q9HRaY6qe9L+1do9OHRUIcjVmg== X-Received: by 2002:a17:902:a981:: with SMTP id bh1mr4197269plb.236.1566570276310; Fri, 23 Aug 2019 07:24:36 -0700 (PDT) Received: from [172.26.99.184] ([2620:10d:c090:180::b6f7]) by smtp.gmail.com with ESMTPSA id ev3sm17073026pjb.3.2019.08.23.07.24.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Aug 2019 07:24:35 -0700 (PDT) From: "Jonathan Lemon" To: "Michael Chan" Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel-team Subject: Re: [PATCH net-next] bnxt_en: Fix allocation of zero statistics block size regression. Date: Fri, 23 Aug 2019 07:24:34 -0700 X-Mailer: MailMate (1.12.5r5635) Message-ID: In-Reply-To: <1566539501-5884-1-git-send-email-michael.chan@broadcom.com> References: <1566539501-5884-1-git-send-email-michael.chan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 22 Aug 2019, at 22:51, Michael Chan wrote: > Recent commit added logic to determine the appropriate statistics > block > size to allocate and the size is stored in bp->hw_ring_stats_size. > But > if the firmware spec is older than 1.6.0, it is 0 and not initialized. > This causes the allocation to fail with size 0 and bnxt_open() to > abort. Fix it by always initializing bp->hw_ring_stats_size to the > legacy default size value. > > Fixes: 4e7485066373 ("bnxt_en: Allocate the larger per-ring statistics > block for 57500 chips.") > Reported-by: Jonathan Lemon > Signed-off-by: Michael Chan Tested-by: Jonathan Lemon Acked-by: Jonathan Lemon Thanks, Michael! -- Jonathan