netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Guvva, Vijaya" <Vijaya.Guvva@cavium.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
	"Manlunas, Felix" <Felix.Manlunas@cavium.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@cavium.com>,
	"Chickles, Derek" <Derek.Chickles@cavium.com>,
	"Burla, Satananda" <Satananda.Burla@cavium.com>
Subject: RE: [PATCH V2 net-next 1/2] liquidio: switchdev support for LiquidIO NIC
Date: Tue, 31 Oct 2017 19:32:01 +0000	[thread overview]
Message-ID: <DM3PR07MB215455E6D8BD6A802A8289FBE15E0@DM3PR07MB2154.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20171027164505.4cc0df92@cakuba.netronome.com>

Thanks Jakub for reviewing the changes.

> SWITCHDEV_ATTR_ID_PORT_PARENT_ID is generally used to determine
> whether two ports belong to the same switch.  Do you not want to support rules
> which redirect packets from one PF (and it's VFs) to the other?
> 
We would be presenting each PF as a separate switch in switchdev model.
So, will be returning separate switchID for each PF.

> Also if you plug two cards into one system, the above will make you offload
> redirect between the cards.  Is that what you want?  Commonly the MAC
> address of the first port or serial number would be used here to make sure IDs
> are unique for each device.
This was done to have static UDEV rules which works on all liquidIO devices. We will resubmit patches for using mac address as switchID.

Thanks,
Vijay

  reply	other threads:[~2017-10-31 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 19:08 [PATCH V2 net-next 0/2] liquidio: Switchdev support for LiquidIO NIC Felix Manlunas
2017-10-27 19:09 ` [PATCH V2 net-next 1/2] liquidio: switchdev " Felix Manlunas
2017-10-27 23:45   ` Jakub Kicinski
2017-10-31 19:32     ` Guvva, Vijaya [this message]
2017-10-27 19:09 ` [PATCH V2 net-next 2/2] liquidio: Configure switchdev with devlink Felix Manlunas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3PR07MB215455E6D8BD6A802A8289FBE15E0@DM3PR07MB2154.namprd07.prod.outlook.com \
    --to=vijaya.guvva@cavium.com \
    --cc=Derek.Chickles@cavium.com \
    --cc=Felix.Manlunas@cavium.com \
    --cc=Raghu.Vatsavayi@cavium.com \
    --cc=Satananda.Burla@cavium.com \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).