netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] farsync: fix support for over 30 cards
@ 2012-10-09  7:20 Dan Carpenter
  2012-10-09 17:55 ` David Miller
  2013-07-26 10:13 ` Updated FarSync driver Kevin Curtis
  0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2012-10-09  7:20 UTC (permalink / raw)
  To: Kevin Curtis; +Cc: netdev, kernel-janitors, David S. Miller

We're trying to fill a 64 bit bitmap but only the lower 30 shifts work
because the shift wraps around.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff.  No one actually has over 30 of these cards...  :P

diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 1a62318..b627132 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -597,7 +597,7 @@ fst_q_work_item(u64 * queue, int card_index)
 	 * bottom half for the card.  Note the limitation of 64 cards.
 	 * That ought to be enough
 	 */
-	mask = 1 << card_index;
+	mask = (u64)1 << card_index;
 	*queue |= mask;
 	spin_unlock_irqrestore(&fst_work_q_lock, flags);
 }

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [patch] farsync: fix support for over 30 cards
  2012-10-09  7:20 [patch] farsync: fix support for over 30 cards Dan Carpenter
@ 2012-10-09 17:55 ` David Miller
  2013-07-26 10:13 ` Updated FarSync driver Kevin Curtis
  1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2012-10-09 17:55 UTC (permalink / raw)
  To: dan.carpenter; +Cc: kevin.curtis, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 9 Oct 2012 10:20:48 +0300

> We're trying to fill a 64 bit bitmap but only the lower 30 shifts work
> because the shift wraps around.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Updated FarSync driver
  2012-10-09  7:20 [patch] farsync: fix support for over 30 cards Dan Carpenter
  2012-10-09 17:55 ` David Miller
@ 2013-07-26 10:13 ` Kevin Curtis
  2013-07-26 23:41   ` Dan Carpenter
  1 sibling, 1 reply; 5+ messages in thread
From: Kevin Curtis @ 2013-07-26 10:13 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, kernel-janitors

Hi David,
    I'd like to update the FarSync driver for our T-Series cards in the latest Linux Kernel and I would also like to add a new driver for our FarSync Flex USB device.

Should I direct the patch to you?


Regards


Kevin Curtis
Linux Development
FarSite Communications Ltd http://www.farsite.com
Winner of The Queen's Award for Enterprise 2009
tel:  +44 1256 330461
fax:  +44 1256 854931



--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Updated FarSync driver
  2013-07-26 10:13 ` Updated FarSync driver Kevin Curtis
@ 2013-07-26 23:41   ` Dan Carpenter
  2013-07-27 20:27     ` govind
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2013-07-26 23:41 UTC (permalink / raw)
  To: Kevin Curtis; +Cc: David S. Miller, netdev, kernel-janitors

On Fri, Jul 26, 2013 at 11:13:25AM +0100, Kevin Curtis wrote:
> Hi David,
>     I'd like to update the FarSync driver for our T-Series cards
> in the latest Linux Kernel and I would also like to add a new
> driver for our FarSync Flex USB device.
> 
> Should I direct the patch to you?
> 

Read Documentation/SubmittingPatches
Use ./scripts/get_maintainer.pl to find who needs to be CC'd.

If you want, you can send your first attempt to kernel-janitors
without CC'ing Dave and netdev and we will tell you which bits of
SubmittingPatches you have missed.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Updated FarSync driver
  2013-07-26 23:41   ` Dan Carpenter
@ 2013-07-27 20:27     ` govind
  0 siblings, 0 replies; 5+ messages in thread
From: govind @ 2013-07-27 20:27 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Kevin Curtis, David S. Miller, netdev, kernel-janitors

On 07/27/2013 05:11 AM, Dan Carpenter wrote:
> On Fri, Jul 26, 2013 at 11:13:25AM +0100, Kevin Curtis wrote:
>> Hi David,
>>      I'd like to update the FarSync driver for our T-Series cards
>> in the latest Linux Kernel and I would also like to add a new
>> driver for our FarSync Flex USB device.
>>
>> Should I direct the patch to you?
>>
>
> Read Documentation/SubmittingPatches
> Use ./scripts/get_maintainer.pl to find who needs to be CC'd.

you can also go through

Write and Submit your first Linux kernel Patch - Greg KH 
https://www.youtube.com/watch?v=LLBrBBImJt4
Why I dont want your code - Greg KH https://www.youtube.com/watch?v=fMeH7wqOwXA

helped me a lot.

//govind

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-07-27 20:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09  7:20 [patch] farsync: fix support for over 30 cards Dan Carpenter
2012-10-09 17:55 ` David Miller
2013-07-26 10:13 ` Updated FarSync driver Kevin Curtis
2013-07-26 23:41   ` Dan Carpenter
2013-07-27 20:27     ` govind

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).