From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8CCC433EF for ; Tue, 14 Sep 2021 06:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FAE260C51 for ; Tue, 14 Sep 2021 06:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240085AbhINGSR (ORCPT ); Tue, 14 Sep 2021 02:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240092AbhINGSP (ORCPT ); Tue, 14 Sep 2021 02:18:15 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73573C061764 for ; Mon, 13 Sep 2021 23:16:58 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id hx25so3428705ejc.6 for ; Mon, 13 Sep 2021 23:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tJimLaSi/Y2g5hOELmbspRvHOYnQL67WURJ74CJWqAY=; b=B14Jo0+joCzHGGHHzEhI/Hnm4RerS0Fcm6JGYMwZH1AwHYkank+ZeqOQlEiGUBFtJC JRHaVsVcV8+as0NdUSS0ZrfrsXhzcmrllunjj5giBBHmO/oQv4BQyxtbTyT9jk7zWuFL ZH1L3SshFOIQCGs3+cWcaG62oHcNyTs7ykjpB9M5UFB4k+1ZnHpdjb1h/HiJk2txe2oR i8slWx/fvvz8GwN503wOAdigRbVVDyFrq/ld9K8D7IHm+JzXgP2Rhh1Li5NOJD0sYNXJ ti/DH/eyLxWy0zqEz21plKrJnMY+ip7Ofejizu5FRtW6aM7tMqqihyghLD9amXQG2ry9 wJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tJimLaSi/Y2g5hOELmbspRvHOYnQL67WURJ74CJWqAY=; b=ZIP8gsuZOPSfAMDHPgFTxr1tiJmqIcIjvRUQIb3QtEV37SmsA1mfj5IOyjDA7ueGme ICcQJ+2mEw6kfFJK2O79O/0H+7RvGW64bbDn+aslYDkHWDjZXMGsfqzQeBHun8ivE3tf dKAVTtxXY8ZcMAlntuCQ5n8B4iabEEN9SASBZoMBM9ky4KAQPvh4U5b2AufATSLLBXwX khhwa3Eo3qYzD9U5A88ozHepsOabmagxgG/jAlVAMzQ6zWl2RNcjN9VYQdS0nulUxG6w ejUciDf10MaYwOx6u0Mjq2IhPSC+4D/8YsQhya4KXczoS6DRl18Zx4QsqRi6+XiUnAqI 2u0w== X-Gm-Message-State: AOAM533KEuuAKeHIzwJ7DZsd1KSqnNhmbTVU19hstYA4jhyNK+tOe4Ab qwMHQrDhzo+wOGIwxRInEN4= X-Google-Smtp-Source: ABdhPJyHkCDry7s2psir/YD3axETIHrGfYwmf2Nr+YXY9fP37b+EQfYJYJ/UookabBewE/7qx1Lx+g== X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr16944849ejb.251.1631600216944; Mon, 13 Sep 2021 23:16:56 -0700 (PDT) Received: from smtpclient.apple ([178.254.237.20]) by smtp.gmail.com with ESMTPSA id s4sm2577820eja.23.2021.09.13.23.16.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Sep 2021 23:16:56 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: Urgent Bug report: PPPoE ioctl(PPPIOCCONNECT): Transport endpoint is not connected From: Martin Zaharinov In-Reply-To: Date: Tue, 14 Sep 2021 09:16:55 +0300 Cc: =?utf-8?Q?Pali_Roh=C3=A1r?= , Greg KH , netdev , Eric Dumazet Content-Transfer-Encoding: quoted-printable Message-Id: References: <7EE80F78-6107-4C6E-B61D-01752D44155F@gmail.com> <08EC1CDD-21C4-41AB-B6A8-1CC2D40F5C05@gmail.com> <20210808152318.6nbbaj3bp6tpznel@pali> <8BDDA0B3-0BEE-4E80-9686-7F66CF58B069@gmail.com> <20210809151529.ymbq53f633253loz@pali> <20210811164835.GB15488@pc-32.home> <81FD1346-8CE6-4080-84C9-705E2E5E69C0@gmail.com> <6A3B4C11-EF48-4CE9-9EC7-5882E330D7EA@gmail.com> To: Guillaume Nault X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Nault See this stats : Linux 5.14.2 (testb) 09/14/21 _x86_64_ (12 CPU) 11:33:44 CPU %usr %nice %sys %iowait %irq %soft %steal = %guest %gnice %idle 11:33:45 all 1.75 0.00 18.85 0.00 0.00 5.00 0.00 = 0.00 0.00 74.40 11:33:46 all 1.74 0.00 17.88 0.00 0.00 4.72 0.00 = 0.00 0.00 75.66 11:33:47 all 2.23 0.00 17.62 0.00 0.00 5.05 0.00 = 0.00 0.00 75.10 11:33:48 all 1.82 0.00 13.64 0.00 0.00 5.70 0.00 = 0.00 0.00 78.84 11:33:49 all 1.50 0.00 13.46 0.00 0.00 5.15 0.00 = 0.00 0.00 79.90 11:33:50 all 3.06 0.00 13.96 0.00 0.00 4.79 0.00 = 0.00 0.00 78.20 11:33:51 all 1.40 0.00 16.53 0.00 0.00 5.21 0.00 = 0.00 0.00 76.86 11:33:52 all 4.43 0.00 19.44 0.00 0.00 6.56 0.00 = 0.00 0.00 69.57 11:33:53 all 1.51 0.00 16.40 0.00 0.00 4.77 0.00 = 0.00 0.00 77.32 11:33:54 all 1.51 0.00 16.55 0.00 0.00 4.71 0.00 = 0.00 0.00 77.23 11:33:55 all 1.00 0.00 13.21 0.00 0.00 5.90 0.00 = 0.00 0.00 79.90 Average: all 2.00 0.00 16.14 0.00 0.00 5.23 0.00 = 0.00 0.00 76.63 PerfTop: 28046 irqs/sec kernel:96.3% exact: 100.0% lost: 0/0 drop: = 0/0 [4000Hz cycles], (all, 12 CPUs) = --------------------------------------------------------------------------= --------------------------------------------------------------------------= ----------------------------------------------------------- 23.37% [nf_conntrack] [k] nf_ct_iterate_cleanup 17.76% [kernel] [k] mutex_spin_on_owner 9.47% [pppoe] [k] pppoe_rcv 7.71% [kernel] [k] osq_lock 2.77% [nf_nat] [k] inet_cmp 2.59% [nf_nat] [k] device_cmp 2.55% [kernel] [k] __local_bh_enable_ip 2.04% [kernel] [k] _raw_spin_lock 1.23% [kernel] [k] __cond_resched 1.16% [kernel] [k] rcu_all_qs 1.13% libfrr.so.0.0.0 [.] 0x00000000000ce970 0.79% [nf_conntrack] [k] nf_conntrack_lock 0.75% libfrr.so.0.0.0 [.] 0x00000000000ce94e 0.53% [kernel] [k] = __netif_receive_skb_core.constprop.0 0.46% [kernel] [k] fib_table_lookup 0.46% [ip_tables] [k] ipt_do_table 0.45% [ixgbe] [k] ixgbe_clean_rx_irq 0.37% [kernel] [k] __dev_queue_xmit 0.34% [nf_conntrack] [k] __nf_conntrack_find_get.isra.0 0.33% [ixgbe] [k] ixgbe_clean_tx_irq 0.30% [kernel] [k] menu_select 0.25% [kernel] [k] vlan_do_receive 0.21% [kernel] [k] ip_finish_output2 0.21% [ixgbe] [k] ixgbe_poll 0.20% [kernel] [k] _raw_spin_lock_irqsave 0.19% [kernel] [k] get_rps_cpu 0.19% libc.so.6 [.] 0x0000000000186afa 0.19% [kernel] [k] queued_read_lock_slowpath 0.19% [kernel] [k] do_poll.constprop.0 0.19% [kernel] [k] cpuidle_enter_state 0.18% [kernel] [k] dev_hard_start_xmit 0.18% [kernel] [k] ___slab_alloc.constprop.0 0.17% zebra [.] 0x00000000000b9271 0.16% [kernel] [k] csum_partial_copy_generic 0.16% zebra [.] 0x00000000000b91f1 0.16% [kernel] [k] page_frag_free 0.16% [kernel] [k] kmem_cache_alloc 0.15% [kernel] [k] __skb_flow_dissect 0.15% [kernel] [k] sched_clock 0.15% libc.so.6 [.] 0x00000000000965a2 0.15% [kernel] [k] kmem_cache_free_bulk.part.0 0.15% [pppoe] [k] pppoe_flush_dev 0.15% [ixgbe] [k] ixgbe_tx_map 0.14% [kernel] [k] _raw_spin_lock_bh 0.14% [kernel] [k] fib_table_flush 0.14% [kernel] [k] native_irq_return_iret 0.14% [kernel] [k] __dev_xmit_skb 0.13% [kernel] [k] nf_hook_slow 0.13% [kernel] [k] fib_lookup_good_nhc 0.12% [kernel] [k] __fget_files 0.12% [kernel] [k] process_backlog 0.12% [xt_dtvqos] [k] 0x00000000000008d1 0.12% [kernel] [k] __list_del_entry_valid 0.12% [kernel] [k] skb_release_data 0.12% [kernel] [k] ip_route_input_slow 0.11% [kernel] [k] netif_skb_features 0.11% [kernel] [k] sock_poll 0.11% [kernel] [k] __schedule 0.11% [kernel] [k] __softirqentry_text_start And on time of problem when try to write : ip a=20 to list interface wait 15-20 sec i finaly have options to simulate but = users is angry when down internet. In case need to know why system is overloaded when deconfig ppp = interface. Best regards, Martin > On 11 Sep 2021, at 9:26, Martin Zaharinov wrote: >=20 > Hi Guillaume >=20 > Main problem is overload of service because have many finishing ppp = (customer) last two day down from 40-50 to 100-200 users and make = problem when is happen if try to type : ip a wait 10-20 sec to start = list interface . > But how to find where is a problem any locking or other. > And is there options to make fast remove ppp interface from kernel to = reduce this load. >=20 >=20 > Martin >=20 >> On 7 Sep 2021, at 9:42, Martin Zaharinov wrote: >>=20 >> Perf top from text >>=20 >>=20 >> PerfTop: 28391 irqs/sec kernel:98.0% exact: 100.0% lost: 0/0 = drop: 0/0 [4000Hz cycles], (all, 12 CPUs) >> = --------------------------------------------------------------------------= --------------------------------------------------------------------------= ----------------------------------------------------------- >>=20 >> 17.01% [nf_conntrack] [k] nf_ct_iterate_cleanup >> 9.73% [kernel] [k] mutex_spin_on_owner >> 9.07% [pppoe] [k] pppoe_rcv >> 2.77% [nf_nat] [k] device_cmp >> 1.66% [kernel] [k] osq_lock >> 1.65% [kernel] [k] _raw_spin_lock >> 1.61% [kernel] [k] __local_bh_enable_ip >> 1.35% [nf_nat] [k] inet_cmp >> 1.30% [kernel] [k] = __netif_receive_skb_core.constprop.0 >> 1.16% [kernel] [k] menu_select >> 0.99% [kernel] [k] cpuidle_enter_state >> 0.96% [ixgbe] [k] ixgbe_clean_rx_irq >> 0.86% [kernel] [k] __dev_queue_xmit >> 0.70% [kernel] [k] __cond_resched >> 0.69% [sch_cake] [k] cake_dequeue >> 0.67% [nf_tables] [k] nft_do_chain >> 0.63% [kernel] [k] rcu_all_qs >> 0.61% [kernel] [k] fib_table_lookup >> 0.57% [kernel] [k] __schedule >> 0.57% [kernel] [k] skb_release_data >> 0.54% [kernel] [k] sched_clock >> 0.54% [kernel] [k] __copy_skb_header >> 0.53% [kernel] [k] dev_queue_xmit_nit >> 0.53% [kernel] [k] _raw_spin_lock_irqsave >> 0.50% [kernel] [k] kmem_cache_free >> 0.48% libfrr.so.0.0.0 [.] 0x00000000000ce970 >> 0.47% [ixgbe] [k] ixgbe_clean_tx_irq >> 0.45% [kernel] [k] timerqueue_add >> 0.45% [kernel] [k] lapic_next_deadline >> 0.45% [kernel] [k] csum_partial_copy_generic >> 0.44% [nf_flow_table] [k] nf_flow_offload_ip_hook >> 0.44% [kernel] [k] kmem_cache_alloc >> 0.44% [nf_conntrack] [k] nf_conntrack_lock >>=20 >>> On 7 Sep 2021, at 9:16, Martin Zaharinov wrote: >>>=20 >>> Hi=20 >>> Sorry for delay but not easy to catch moment . >>>=20 >>>=20 >>> See this is mpstatl 1 : >>>=20 >>> Linux 5.14.1 (demobng) 09/07/21 _x86_64_ (12 CPU) >>>=20 >>> 11:12:16 CPU %usr %nice %sys %iowait %irq %soft = %steal %guest %gnice %idle >>> 11:12:17 all 0.17 0.00 6.66 0.00 0.00 4.13 = 0.00 0.00 0.00 89.05 >>> 11:12:18 all 0.25 0.00 8.36 0.00 0.00 4.88 = 0.00 0.00 0.00 86.51 >>> 11:12:19 all 0.26 0.00 9.62 0.00 0.00 3.91 = 0.00 0.00 0.00 86.21 >>> 11:12:20 all 0.85 0.00 6.00 0.00 0.00 4.31 = 0.00 0.00 0.00 88.84 >>> 11:12:21 all 0.08 0.00 4.45 0.00 0.00 4.79 = 0.00 0.00 0.00 90.67 >>> 11:12:22 all 0.17 0.00 9.50 0.00 0.00 4.58 = 0.00 0.00 0.00 85.75 >>> 11:12:23 all 0.00 0.00 6.92 0.00 0.00 2.48 = 0.00 0.00 0.00 90.61 >>> 11:12:24 all 0.17 0.00 5.45 0.00 0.00 4.27 = 0.00 0.00 0.00 90.11 >>> 11:12:25 all 0.25 0.00 5.38 0.00 0.00 4.79 = 0.00 0.00 0.00 89.58 >>> 11:12:26 all 0.60 0.00 1.45 0.00 0.00 2.65 = 0.00 0.00 0.00 95.30 >>> 11:12:27 all 0.42 0.00 6.91 0.00 0.00 4.47 = 0.00 0.00 0.00 88.20 >>> 11:12:28 all 0.00 0.00 6.75 0.00 0.00 4.18 = 0.00 0.00 0.00 89.07 >>> 11:12:29 all 0.17 0.00 3.52 0.00 0.00 5.11 = 0.00 0.00 0.00 91.20 >>> 11:12:30 all 1.45 0.00 10.14 0.00 0.00 3.49 = 0.00 0.00 0.00 84.92 >>> 11:12:31 all 0.09 0.00 5.11 0.00 0.00 4.77 = 0.00 0.00 0.00 90.03 >>> 11:12:32 all 0.25 0.00 3.11 0.00 0.00 4.46 = 0.00 0.00 0.00 92.17 >>> Average: all 0.32 0.00 6.21 0.00 0.00 4.21 = 0.00 0.00 0.00 89.26 >>>=20 >>>=20 >>> I attache and one screenshot from perf top (Screenshot is send on = preview mail) >>>=20 >>> And I see in lsmod=20 >>>=20 >>> pppoe 20480 8198 >>> pppox 16384 1 pppoe >>> ppp_generic 45056 16364 pppox,pppoe >>> slhc 16384 1 ppp_generic >>>=20 >>> To slow remove pppoe session . >>>=20 >>> And from log :=20 >>>=20 >>> [2021-09-07 11:01:11.129] vlan3020: ebdd1c5d8b5900f6: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:01:53.621] vlan643: ebdd1c5d8b59014e: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:00.359] vlan1616: ebdd1c5d8b590195: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:05.859] vlan3020: ebdd1c5d8b5900d8: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:08.258] vlan3005: ebdd1c5d8b590190: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:13.820] vlan643: ebdd1c5d8b590152: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:15.839] vlan727: ebdd1c5d8b590144: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>> [2021-09-07 11:02:20.139] vlan1693: ebdd1c5d8b59019f: = ioctl(PPPIOCCONNECT): Transport endpoint is not connected >>>=20 >>>> On 11 Aug 2021, at 19:48, Guillaume Nault = wrote: >>>>=20 >>>> On Wed, Aug 11, 2021 at 02:10:32PM +0300, Martin Zaharinov wrote: >>>>> And one more that see. >>>>>=20 >>>>> Problem is come when accel start finishing sessions, >>>>> Now in server have 2k users and restart on one of vlans 3 Olt with = 400 users and affect other vlans , >>>>> And problem is start when start destroying dead sessions from vlan = with 3 Olt and this affect all other vlans. >>>>> May be kernel destroy old session slow and entrained other users = by locking other sessions. >>>>> is there a way to speed up the closing of stopped/dead sessions. >>>>=20 >>>> What are the CPU stats when that happen? Is it users space or = kernel >>>> space that keeps it busy? >>>>=20 >>>> One easy way to check is to run "mpstat 1" for a few seconds when = the >>>> problem occurs. >>>>=20 >>>=20 >>=20 >=20