From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helmut Grohne Subject: Re: TUN/TAP: tap driver reports bogus interface speed in ethtool operations Date: Tue, 30 Jul 2013 08:20:43 +0200 Message-ID: References: <2F174B03-5074-4BA0-B91A-8F2F62C2B082@cygnusnetworks.de> <5192BDD6.6060703@qti.qualcomm.com> <3E916AF0-C587-443D-B653-C968A96C8751@cygnusnetworks.de> <48A2F278-A32C-47C6-AD2D-1FC15EC73B88@cygnusnetworks.de> <51E5BE27.3060207@qti.qualcomm.com> <1374606278.2072.11.camel@bwh-desktop.uk.level5networks.com> Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Miller , Max Krasnyansky , Stephen Hemminger To: Ben Hutchings Return-path: Received: from mail2.w359.de ([46.189.116.21]:39002 "EHLO mail2.w359.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267Ab3G3GUX (ORCPT ); Tue, 30 Jul 2013 02:20:23 -0400 In-Reply-To: <1374606278.2072.11.camel@bwh-desktop.uk.level5networks.com> Sender: netdev-owner@vger.kernel.org List-ID: Thanks for your review! Given the v2 patch Stephen Hemminger posted, I think that his series is where development should continue. On 23.07.2013, at 21:04, Ben Hutchings wrote: > This is formatted wrongly - needs a space after 'if' and all the > continuation lines should be lined up under 'cmd->supported'. I am sorry for not having run checkpatch and will try to remember next time. >> + return -EOPNOTSUPP; > > EINVAL Makes sense, once you are pointed to it. > I notice the port type is reported as PORT_TP. Perhaps that should also > be changed to PORT_NONE (in a separate patch)? This appears not yet addressed in the v2 patch yet. I am not sure how to go on here. Clearly the v2 patch set, is an improvement over my initial version. The additional capabilities of changing the reported driver and similar aspects appear controversial though. Would it make sense to split this into two patch sets to be handled independently? Helmut