From: <Jerry.Ray@microchip.com>
To: <Arun.Ramadoss@microchip.com>, <olteanv@gmail.com>,
<andrew@lunn.ch>, <linux-kernel@vger.kernel.org>,
<linux@armlinux.org.uk>, <f.fainelli@gmail.com>,
<kuba@kernel.org>, <edumazet@google.com>, <pabeni@redhat.com>,
<jbe@pengutronix.de>, <netdev@vger.kernel.org>,
<davem@davemloft.net>
Subject: RE: [PATCH net-next v6 6/6] dsa: lan9303: Migrate to PHYLINK
Date: Mon, 16 Jan 2023 17:33:06 +0000 [thread overview]
Message-ID: <MWHPR11MB169365CB3BE33AFBF6566277EFC19@MWHPR11MB1693.namprd11.prod.outlook.com> (raw)
In-Reply-To: <39a76c164362f5e03238666e194fc135b19ade12.camel@microchip.com>
> > diff --git a/drivers/net/dsa/lan9303-core.c
> > b/drivers/net/dsa/lan9303-core.c
> > index 7be4c491e5d9..e514fff81af6 100644
> > --- a/drivers/net/dsa/lan9303-core.c
> > +++ b/drivers/net/dsa/lan9303-core.c
> > @@ -1058,37 +1058,6 @@ static int lan9303_phy_write(struct dsa_switch
> > *ds, int phy, int regnum,
> > return chip->ops->phy_write(chip, phy, regnum, val);
> > }
> >
> > +static void lan9303_phylink_get_caps(struct dsa_switch *ds, int
> > port,
> > + struct phylink_config *config)
> > +{
> > + struct lan9303 *chip = ds->priv;
> > +
> > + dev_dbg(chip->dev, "%s(%d) entered.", __func__, port);
> > +
> > + config->mac_capabilities = MAC_10 | MAC_100 | MAC_ASYM_PAUSE |
> > + MAC_SYM_PAUSE;
> > +
> > + if (port == 0) {
> > + __set_bit(PHY_INTERFACE_MODE_RMII,
> > + config->supported_interfaces);
> > + __set_bit(PHY_INTERFACE_MODE_MII,
> > + config->supported_interfaces);
> > + } else {
> > + __set_bit(PHY_INTERFACE_MODE_INTERNAL,
> > + config->supported_interfaces);
> > + /* Compatibility for phylib's default interface type
> > when the
> > + * phy-mode property is absent
> > + */
> > + __set_bit(PHY_INTERFACE_MODE_GMII,
> > + config->supported_interfaces);
> > + }
> > +
> > + /* This driver does not make use of the speed, duplex, pause or
> > the
> > + * advertisement in its mac_config, so it is safe to mark this
> > driver
> > + * as non-legacy.
> > + */
> > + config->legacy_pre_march2020 = false;
> > +}
> > +
> > +static void lan9303_phylink_mac_link_up(struct dsa_switch *ds, int
> > port,
> > + unsigned int mode,
> > + phy_interface_t interface,
> > + struct phy_device *phydev, int
> > speed,
> > + int duplex, bool tx_pause,
> > + bool rx_pause)
> > +{
> > + u32 ctl;
> > +
> > + /* On this device, we are only interested in doing something
> > here if
> > + * this is the xMII port. All other ports are 10/100 phys using
> > MDIO
> > + * to control there link settings.
> > + */
> > + if (port != 0)
> > + return;
> > +
> > + ctl = lan9303_phy_read(ds, port, MII_BMCR);
> > +
> > + ctl &= ~BMCR_ANENABLE;
> > +
> > + if (speed == SPEED_100)
> > + ctl |= BMCR_SPEED100;
> > + else if (speed == SPEED_10)
> > + ctl &= ~BMCR_SPEED100;
> > + else
> > + dev_err(ds->dev, "unsupported speed: %d\n", speed);
>
> I think, We will not reach in the error part, since in the
> phylink_get_caps we specified only 10 and 100 Mbps speed. Phylink layer
> will validate and if the value is beyond the speed supported, it will
> return back.
>
I will remove the error check and will go with either 10 or 100.
ctl &= ~BMCR_SPEED100;
if ((speed == SPEED_100)
ctl |= BMCR_SPEED100;
Regards,
Jerry.
> > +
> > + if (duplex == DUPLEX_FULL)
> > + ctl |= BMCR_FULLDPLX;
> > + else
> > + ctl &= ~BMCR_FULLDPLX;
> > +
> > + lan9303_phy_write(ds, port, MII_BMCR, ctl);
> > +}
> > +
next prev parent reply other threads:[~2023-01-16 17:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 21:18 [PATCH net-next v6 0/6] dsa: lan9303: Move to PHYLINK Jerry Ray
2023-01-09 21:18 ` [PATCH net-next v6 1/6] dsa: lan9303: align dsa_switch_ops members Jerry Ray
2023-01-11 22:04 ` Vladimir Oltean
2023-01-11 22:07 ` Florian Fainelli
2023-01-09 21:18 ` [PATCH net-next v6 2/6] dsa: lan9303: move Turbo Mode bit init Jerry Ray
2023-01-14 20:49 ` Vladimir Oltean
2023-01-16 18:03 ` Jerry.Ray
2023-01-16 18:06 ` Jerry.Ray
2023-01-09 21:18 ` [PATCH net-next v6 3/6] dsa: lan9303: Add exception logic for read failure Jerry Ray
2023-01-09 21:18 ` [PATCH net-next v6 4/6] dsa: lan9303: write reg only if necessary Jerry Ray
2023-01-09 21:18 ` [PATCH net-next v6 5/6] dsa: lan9303: Port 0 is xMII port Jerry Ray
2023-01-14 20:53 ` Vladimir Oltean
2023-01-16 18:05 ` Jerry.Ray
2023-01-09 21:18 ` [PATCH net-next v6 6/6] dsa: lan9303: Migrate to PHYLINK Jerry Ray
2023-01-12 5:22 ` Arun.Ramadoss
2023-01-16 17:33 ` Jerry.Ray [this message]
2023-01-12 11:48 ` Russell King (Oracle)
2023-01-16 17:22 ` Jerry.Ray
2023-01-16 18:03 ` Russell King (Oracle)
2023-01-16 22:48 ` Jerry.Ray
2023-01-17 18:19 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB169365CB3BE33AFBF6566277EFC19@MWHPR11MB1693.namprd11.prod.outlook.com \
--to=jerry.ray@microchip.com \
--cc=Arun.Ramadoss@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jbe@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).