From: Biju Das <biju.das.jz@bp.renesas.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: RE: [PATCH net-next v3] ravb: Add RZ/G2L MII interface support
Date: Wed, 14 Sep 2022 17:35:55 +0000 [thread overview]
Message-ID: <OS0PR01MB59224746A9C18AB933498AEB86469@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <34db8b96-624a-09e5-24e1-9b8be375a6c8@omp.ru>
Hi Sergey,
> Subject: Re: [PATCH net-next v3] ravb: Add RZ/G2L MII interface support
>
> On 9/14/22 8:20 PM, Biju Das wrote:
>
> [...]
> >>> EMAC IP found on RZ/G2L Gb ethernet supports MII interface.
> >>> This patch adds support for selecting MII interface mode.
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>> ---
> >>> v2->v3:
> >>> * Documented CXR35_HALFCYC_CLKSW1000 and CXR35_SEL_XMII_MII macros.
> >>
> >> I definitely didn't mean it done this way...
> >>
> >> [...]
> >>> diff --git a/drivers/net/ethernet/renesas/ravb.h
> >>> b/drivers/net/ethernet/renesas/ravb.h
> >>> index b980bce763d3..058aceac8c92 100644
> >>> --- a/drivers/net/ethernet/renesas/ravb.h
> >>> +++ b/drivers/net/ethernet/renesas/ravb.h
> >> [...]
> >>> @@ -965,6 +966,11 @@ enum CXR31_BIT {
> >>> CXR31_SEL_LINK1 = 0x00000008,
> >>> };
> >>>
> >>> +enum CXR35_BIT {
> >>> + CXR35_HALFCYC_CLKSW1000 = 0x03E80000, /* 1000 cycle of clk_chi
> >> */
> >>
> >> No, please just declare:
> >
> >
> >>
> >> CXR35_HALFCYC_CLKSW = 0xffff0000,
> >
> > Q1) Why do you think we should use this value for setting MII?
>
> Where are you seeing me asking for that? This is just the field
> declaration, correct against the manual... we can safely omit it as
> well...
OK will keep it as field declaration and use actual value during setting.
>
> [...]
> >>> + CXR35_SEL_XMII_MII = 0x00000002, /* MII interface is used
> >> */
> >>
> >> All the other register *enum*s are declared from LSB to MSB. The
> >> comment is pretty self-obvious here, please remove it. And declare
> >> the whole field too:
> >>
> >> CXR35_SEL_XMII = 0x00000003,
> >
> > Values 1 and 3 are reserved so we cannot use 3.
>
> Again, this is the filed declaration, correct against the manual...
OK. Will add it.
>
> > I think the current patch holds good as per the hardware manual for
> > selecting MII interface.
>
> It is incomplete, compared against the manual. And declaring
> CXR35_HALFCYC_CLKSW1000 just looks completely ridiculous. :-)
Ok. All good now. Will send 4.
Cheers,
Biju
prev parent reply other threads:[~2022-09-14 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 6:47 [PATCH net-next v3] ravb: Add RZ/G2L MII interface support Biju Das
2022-09-14 17:08 ` Sergey Shtylyov
2022-09-14 17:20 ` Biju Das
2022-09-14 17:29 ` Biju Das
2022-09-14 17:30 ` Sergey Shtylyov
2022-09-14 17:35 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59224746A9C18AB933498AEB86469@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).