netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "ashiduka@fujitsu.com" <ashiduka@fujitsu.com>
To: 'Andrew Lunn' <andrew@lunn.ch>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"torii.ken1@fujitsu.com" <torii.ken1@fujitsu.com>
Subject: RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN
Date: Mon, 18 Jan 2021 10:17:04 +0000	[thread overview]
Message-ID: <OSAPR01MB3844F07254AB8B1164086D7FDFA40@OSAPR01MB3844.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YADN77NvrpnZYUVo@lunn.ch>

Hi Andrew

> > Do you know how to switch between master/slave?
> 
> There was a patch to ethtool merged for this:
> 
> commit 558f7cc33daf82f945af432c79db40edcbe0dad0
> Author: Oleksij Rempel <o.rempel@pengutronix.de>
> Date:   Wed Jun 10 10:37:43 2020 +0200
> 
>     netlink: add master/slave configuration support

I know this.
--
# ./ethtool --version
ethtool version 5.10
# ./ethtool -s eth1 master-slave slave-force 
ethtool (-s): invalid value 'slave-force' for parameter 'master-slave'
--

As I wrote in the previous e-mail, it doesn't work because it doesn't 
include the process to parse the master-slave argument.

> The help of the ethtool command can show about the "master-slave" 
> option, but it doesn't seem to handle the arguments.
> I checked ethtool.c and it seems that do_sset () doesn't implement the 
> process of parsing master-slave arguments...

Once ethtool works properly, I will test the master-slave switching behavior.

  reply	other threads:[~2021-01-18 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  8:52 [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN Yuusuke Ashizuka
2021-01-10 10:23 ` Russell King - ARM Linux admin
2021-01-10 16:22 ` Andrew Lunn
2021-01-12  5:14   ` ashiduka
2021-01-12 13:54     ` Andrew Lunn
2021-01-13  1:10       ` ashiduka
2021-01-14  8:38   ` ashiduka
2021-01-14 23:04     ` Andrew Lunn
2021-01-18 10:17       ` ashiduka [this message]
2021-01-19 15:46         ` Andrew Lunn
2021-01-20 11:32           ` ashiduka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSAPR01MB3844F07254AB8B1164086D7FDFA40@OSAPR01MB3844.jpnprd01.prod.outlook.com \
    --to=ashiduka@fujitsu.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=torii.ken1@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).