netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Lobakin <alobakin@pm.me>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alexander Lobakin <alobakin@pm.me>,
	Ariel Elior <aelior@marvell.com>,
	GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses
Date: Thu, 30 Jul 2020 16:26:17 +0000	[thread overview]
Message-ID: <SKiAD0R1iJX4FHbr-_GUICKdDvuTvqrJjcR2CQEpE_-GCYtJq-lLbDeec-WmOCZ6NIxW6rca1CRm-d1tSRUu2zFyAapHAjvmgvI5iN6Zvp8=@pm.me> (raw)

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 18:59:20 +0300

> Convert to %pM instead of using custom code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_mcp.c   | 5 ++---
>  drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 ++----
>  2 files changed, 4 insertions(+), 7 deletions(-)

Thanks!

Acked-by: Alexander Lobakin <alobakin@pm.me>

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> index 988d84564849..5be08f83e0aa 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> @@ -2518,11 +2518,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn *p_hwfn,
>  	}
>  
>  	DP_VERBOSE(p_hwfn, (QED_MSG_SP | NETIF_MSG_IFUP),
> -		   "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %02x:%02x:%02x:%02x:%02x:%02x wwn port %llx node %llx ovlan %04x wol %02x\n",
> +		   "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %pM wwn port %llx node %llx ovlan %04x wol %02x\n",
>  		info->pause_on_host, info->protocol,
>  		info->bandwidth_min, info->bandwidth_max,
> -		info->mac[0], info->mac[1], info->mac[2],
> -		info->mac[3], info->mac[4], info->mac[5],
> +		info->mac,
>  		info->wwn_port, info->wwn_node,
>  		info->ovlan, (u8)p_hwfn->hw_info.b_wol_support);
>  
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> index aa215eeeb4df..9489089706fe 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> @@ -3276,14 +3276,12 @@ static void qed_iov_vf_mbx_ucast_filter(struct qed_hwfn *p_hwfn,
>  
>  	DP_VERBOSE(p_hwfn,
>  		   QED_MSG_IOV,
> -		   "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %02x:%02x:%02x:%02x:%02x:%02x, vlan 0x%04x\n",
> +		   "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %pM, vlan 0x%04x\n",
>  		   vf->abs_vf_id, params.opcode, params.type,
>  		   params.is_rx_filter ? "RX" : "",
>  		   params.is_tx_filter ? "TX" : "",
>  		   params.vport_to_add_to,
> -		   params.mac[0], params.mac[1],
> -		   params.mac[2], params.mac[3],
> -		   params.mac[4], params.mac[5], params.vlan);
> +		   params.mac, params.vlan);
>  
>  	if (!vf->vport_instance) {
>  		DP_VERBOSE(p_hwfn,
> -- 
> 2.27.0

Al


             reply	other threads:[~2020-07-30 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 16:26 Alexander Lobakin [this message]
2020-08-01 12:21 ` [PATCH v1] qed: Use %pM format specifier for MAC addresses Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2020-07-30 15:59 Andy Shevchenko
2020-07-31 23:48 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='SKiAD0R1iJX4FHbr-_GUICKdDvuTvqrJjcR2CQEpE_-GCYtJq-lLbDeec-WmOCZ6NIxW6rca1CRm-d1tSRUu2zFyAapHAjvmgvI5iN6Zvp8=@pm.me' \
    --to=alobakin@pm.me \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).